public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v8 1/3] platform/x86: move Mellanox hardware platform hotplug driver to platform/mellanox
Date: Mon, 15 Jan 2018 19:42:43 -0800	[thread overview]
Message-ID: <20180116034243.GB4590@fury> (raw)
In-Reply-To: <1515661123-76604-2-git-send-email-vadimp@mellanox.com>

On Thu, Jan 11, 2018 at 08:58:41AM +0000, Vadim Pasternak wrote:
> It moves drivers/platform/x86/mlxcpld-hotplug.c to
> drivers/platform/mellanox/mlxreg-hotplug.c and
> include/linux/platform_data/mlxcpld-hotplug.h to
> include/linux/platform_data/mlxreg.h for making hotplug driver usable for
> the different machine architectures.
> 
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> v7->v8:
> v6->v7:
>  Fixes added by Vadim:
>  - remove dependency on X86_64 to allow also X86 architecture;
> v5->v6:
>  Fixes added by Vadim:
>  - add SPD license record to Kconfig and Makefile;
> v4->v5:
>  Comments pointed out by Andy:
>  - arrange MAINTAINERS in correct alphabetic order;
> v3->v4:
>  Comments pointed out by Darren:
>  - Refactor the patches to provide the changes in patchset in incremental
>    order;
>  - Modify MAINTAINERS records;
>  - Use git-mv for the replaced files;
>   Commnets pointed out by Colin:
>  - Make structures mlxplat_dev and mlxplat_hotplug static;
> ---

...

>  config MLX_PLATFORM
>  	tristate "Mellanox Technologies platform support"
> -	depends on X86_64

This seems like it would be more appropriately applied to 2/3 as this patch is
supposed to be just about the renaming of the files, methods, and defines from
CPLD to reg, and the creation of the mellanox platform.

Any reason this needs to be in this patch?

-- 
Darren Hart
VMware Open Source Technology Center

  reply	other threads:[~2018-01-16  3:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  8:58 [patch v8 0/3] drivers/platform: replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak
2018-01-11  8:58 ` [patch v8 1/3] platform/x86: move Mellanox hardware platform hotplug driver to platform/mellanox Vadim Pasternak
2018-01-16  3:42   ` Darren Hart [this message]
2018-01-16  8:06     ` Vadim Pasternak
2018-01-17  1:52       ` Darren Hart
2018-01-11  8:58 ` [patch v8 2/3] platform/mellanox: mlxreg-hotplug: allow driver for ARM architecture Vadim Pasternak
2018-01-16  3:43   ` Darren Hart
2018-01-16  8:06     ` Vadim Pasternak
2018-01-17  1:50       ` Darren Hart
2018-01-17  1:53         ` Darren Hart
2018-01-11  8:58 ` [patch v8 3/3] platform/mellanox: mlxreg-hotplug: modify to use regmap intreface Vadim Pasternak
2018-01-16  3:43   ` Darren Hart
2018-01-16  3:42 ` [patch v8 0/3] drivers/platform: replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Darren Hart
2018-01-16  3:45   ` Darren Hart
2018-01-16  3:49     ` Darren Hart
2018-01-16  8:08       ` Vadim Pasternak
2018-01-16  3:46   ` Darren Hart
2018-01-16  4:02     ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180116034243.GB4590@fury \
    --to=dvhart@infradead.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=vadimp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox