From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v8 2/3] platform/mellanox: mlxreg-hotplug: allow driver for ARM architecture
Date: Mon, 15 Jan 2018 19:43:13 -0800 [thread overview]
Message-ID: <20180116034313.GC4590@fury> (raw)
In-Reply-To: <1515661123-76604-3-git-send-email-vadimp@mellanox.com>
On Thu, Jan 11, 2018 at 08:58:42AM +0000, Vadim Pasternak wrote:
> It allows driver to run on x86 and ARM architecture based systems.
> Also some unnecessary includes are removed.
Hi Vadim,
These changes are not all readily mapped to this description, nor to the
changelog below.
Only the kconfig change is obviously linked to building on ARM and not just x86.
Things like the removal of the dev_err messages and the relocation of the
create and destroy methods seem entirely unrelated to building on ARM.
I'd like to get this merged sooner rather than later as it has been lingering
for quite some time now - can you provide some more detail about how the changes
included in this patch are needed to make this driver build on ARM?
Thanks,
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-01-16 3:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 8:58 [patch v8 0/3] drivers/platform: replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak
2018-01-11 8:58 ` [patch v8 1/3] platform/x86: move Mellanox hardware platform hotplug driver to platform/mellanox Vadim Pasternak
2018-01-16 3:42 ` Darren Hart
2018-01-16 8:06 ` Vadim Pasternak
2018-01-17 1:52 ` Darren Hart
2018-01-11 8:58 ` [patch v8 2/3] platform/mellanox: mlxreg-hotplug: allow driver for ARM architecture Vadim Pasternak
2018-01-16 3:43 ` Darren Hart [this message]
2018-01-16 8:06 ` Vadim Pasternak
2018-01-17 1:50 ` Darren Hart
2018-01-17 1:53 ` Darren Hart
2018-01-11 8:58 ` [patch v8 3/3] platform/mellanox: mlxreg-hotplug: modify to use regmap intreface Vadim Pasternak
2018-01-16 3:43 ` Darren Hart
2018-01-16 3:42 ` [patch v8 0/3] drivers/platform: replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Darren Hart
2018-01-16 3:45 ` Darren Hart
2018-01-16 3:49 ` Darren Hart
2018-01-16 8:08 ` Vadim Pasternak
2018-01-16 3:46 ` Darren Hart
2018-01-16 4:02 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116034313.GC4590@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox