From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Markus <M4rkusXXL@web.de>, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/2] objtool: Fix seg fault with gold linker
Date: Tue, 16 Jan 2018 09:30:17 +0100 [thread overview]
Message-ID: <20180116083017.4yb3ej67ll5m5m73@gmail.com> (raw)
In-Reply-To: <20180116042046.soi3nmveue6utmtc@treble>
* Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Tue, Jan 16, 2018 at 01:21:44AM +0100, Ingo Molnar wrote:
> >
> > * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> >
> > > Objtool seg faults when the gold linker is used with
> > > CONFIG_MODVERSIONS=y and CONFIG_UNWINDER_ORC=y.
> > >
> > > With CONFIG_MODVERSIONS=y, the .o file gets passed to the linker before
> > > being passed to objtool. The gold linker seems to strip unused ELF
> > > symbols by default, which confuses objtool and causes the seg fault when
> > > it's trying to generate ORC metadata.
> >
> > BTW., if it's still unfixed, could we fix that segfault as well, and turn it into
> > a more useful failure message?
>
> Good point. I'll fix up this seg fault, and the other one
> found/introduced when adding retpoline support.
Thanks!
Ingo
next prev parent reply other threads:[~2018-01-16 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 14:17 [PATCH 1/2] objtool: Fix seg fault with gold linker Josh Poimboeuf
2018-01-15 14:17 ` [PATCH 2/2] objtool: Improve error message for bad file argument Josh Poimboeuf
2018-01-16 3:37 ` [tip:x86/pti] " tip-bot for Josh Poimboeuf
2018-01-16 0:21 ` [PATCH 1/2] objtool: Fix seg fault with gold linker Ingo Molnar
2018-01-16 4:20 ` Josh Poimboeuf
2018-01-16 8:30 ` Ingo Molnar [this message]
2018-01-16 3:37 ` [tip:x86/pti] " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116083017.4yb3ej67ll5m5m73@gmail.com \
--to=mingo@kernel.org \
--cc=M4rkusXXL@web.de \
--cc=a.p.zijlstra@chello.nl \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox