From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751178AbeAPIaW (ORCPT + 1 other); Tue, 16 Jan 2018 03:30:22 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39993 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbeAPIaV (ORCPT ); Tue, 16 Jan 2018 03:30:21 -0500 X-Google-Smtp-Source: ACJfBosBIVPNqEqg0qUWcjX4AYQGcdIGh0oR9y1drbQ/ZkXUGhEamYdkg0pz80ejRjcF3Ahone69dg== Date: Tue, 16 Jan 2018 09:30:17 +0100 From: Ingo Molnar To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Markus , Thomas Gleixner , Peter Zijlstra , Linus Torvalds Subject: Re: [PATCH 1/2] objtool: Fix seg fault with gold linker Message-ID: <20180116083017.4yb3ej67ll5m5m73@gmail.com> References: <355f04da33581f4a3bf82e5b512973624a1e23a2.1516025651.git.jpoimboe@redhat.com> <20180116002144.w6tqxeojrubyanhe@gmail.com> <20180116042046.soi3nmveue6utmtc@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180116042046.soi3nmveue6utmtc@treble> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: * Josh Poimboeuf wrote: > On Tue, Jan 16, 2018 at 01:21:44AM +0100, Ingo Molnar wrote: > > > > * Josh Poimboeuf wrote: > > > > > Objtool seg faults when the gold linker is used with > > > CONFIG_MODVERSIONS=y and CONFIG_UNWINDER_ORC=y. > > > > > > With CONFIG_MODVERSIONS=y, the .o file gets passed to the linker before > > > being passed to objtool. The gold linker seems to strip unused ELF > > > symbols by default, which confuses objtool and causes the seg fault when > > > it's trying to generate ORC metadata. > > > > BTW., if it's still unfixed, could we fix that segfault as well, and turn it into > > a more useful failure message? > > Good point. I'll fix up this seg fault, and the other one > found/introduced when adding retpoline support. Thanks! Ingo