From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Ladislav Michl <ladis@linux-mips.org>,
Roger Quadros <rogerq@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Sebastian Reichel <sre@kernel.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: onenand: omap2: print resource using %pR format string
Date: Tue, 16 Jan 2018 10:44:27 +0100 [thread overview]
Message-ID: <20180116104427.33f55027@bbrezillon> (raw)
In-Reply-To: <20180116074359.2861596-1-arnd@arndb.de>
On Tue, 16 Jan 2018 08:43:40 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> The omap2 onenand driver is now available for compile-testing, which
> uncovers a warning in configurations that have a 64-bit resource_size_t:
>
> drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe':
> drivers/mtd/onenand/omap2.c:536:54: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
> dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
> drivers/mtd/onenand/omap2.c:536:66: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
>
> Changing the format string to the special %pR simplifies the code
> and lets it do the right thing in that configuration, while avoiding
> the warning.
>
Applied. I'll adjust my PR to include this fix.
Thanks,
Boris
> Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mtd/onenand/omap2.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index 2ce73fb6da1c..a4a2159bcfb7 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -533,8 +533,7 @@ static int omap2_onenand_probe(struct platform_device *pdev)
>
> c->onenand.base = devm_ioremap_resource(dev, res);
> if (IS_ERR(c->onenand.base)) {
> - dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
> - res->start, resource_size(res));
> + dev_err(dev, "Cannot reserve memory region %pR\n", res);
> return PTR_ERR(c->onenand.base);
> }
>
prev parent reply other threads:[~2018-01-16 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 7:43 [PATCH] mtd: onenand: omap2: print resource using %pR format string Arnd Bergmann
2018-01-16 8:22 ` Sebastian Reichel
2018-01-16 8:23 ` Peter Ujfalusi
2018-01-16 9:44 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116104427.33f55027@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=kyungmin.park@samsung.com \
--cc=ladis@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=richard@nod.at \
--cc=rogerq@ti.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox