From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276AbeAPOsr (ORCPT + 1 other); Tue, 16 Jan 2018 09:48:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:58378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbeAPOsq (ORCPT ); Tue, 16 Jan 2018 09:48:46 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C1B921721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 16 Jan 2018 11:48:44 -0300 From: Arnaldo Carvalho de Melo To: Jin Yao Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 0/8] perf: Follow-up patches to improve time slice Message-ID: <20180116144844.GB16107@kernel.org> References: <1515596433-24653-1-git-send-email-yao.jin@linux.intel.com> <20180116115519.GA18544@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180116115519.GA18544@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Em Tue, Jan 16, 2018 at 12:55:19PM +0100, Jiri Olsa escreveu: > On Wed, Jan 10, 2018 at 11:00:25PM +0800, Jin Yao wrote: > > It's follow-up patches to improve the perf time slice feature > > (perf report/script --time xxx) > > > > 1. Improve the error message > > perf report: Improve error msg when no first/last sample time found > > perf script: Improve error msg when no first/last sample time found > > > > 2. Fix an issue that illegal percent was accepted previously (e.g. 1abc%) > > perf util: Improve error checking for time percent input > > > > 3. Omit the slice index if possible. For example, > > perf report --stdio --time 10%/1 is equivalent to > > perf report --stdio --time 10% > > > > perf util: Support no index time percent slice > > > > 4. Add indication of time slices in perf report header. > > perf report: Add an indication of what time slices are used > > > > 5. Remove the time slices number limitation in perf report/script > > perf util: Allocate time slices buffer according to number of comma > > perf report: Remove the time slices number limitation > > perf script: Remove the time slices number limitation > > > > Jin Yao (8): > > perf report: Improve error msg when no first/last sample time found > > perf script: Improve error msg when no first/last sample time found > > perf util: Improve error checking for time percent input > > perf util: Support no index time percent slice > > perf report: Add an indication of what time slices are used > > perf util: Allocate time slices buffer according to number of comma > > perf report: Remove the time slices number limitation > > perf script: Remove the time slices number limitation > > from quick look it looks ok > > Reviewed-by: Jiri Olsa Thanks, applied, now test building with 'make -C tools/perf build-test', containers, etc. - Arnaldo