From: Greg KH <gregkh@linuxfoundation.org>
To: Bogdan Purcareata <bogdan.purcareata@nxp.com>
Cc: laurentiu.tudor@nxp.com, ruxandra.radulescu@nxp.com,
devel@driverdev.osuosl.org, robh@kernel.org, stuyoder@gmail.com,
arnd@arndb.de, marc.zyngier@arm.com, roy.pledge@nxp.com,
ioana.ciornei@nxp.com, linux-kernel@vger.kernel.org,
horia.geanta@nxp.com, nipun.gupta@nxp.com, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net
Subject: Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers
Date: Tue, 16 Jan 2018 16:13:12 +0100 [thread overview]
Message-ID: <20180116151312.GA1174@kroah.com> (raw)
In-Reply-To: <1516108750-24938-4-git-send-email-bogdan.purcareata@nxp.com>
On Tue, Jan 16, 2018 at 03:19:05PM +0200, Bogdan Purcareata wrote:
> diff --git a/drivers/staging/fsl-mc/bus/dpbp-cmd.h b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> index 5904836..1ac8ec6 100644
> --- a/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> +++ b/drivers/staging/fsl-mc/bus/dpbp-cmd.h
> @@ -1,33 +1,8 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
Hm, I don't think you want to do that. How can a Linux driver subsytem
that wraps calls to the kernel's driver core (which are GPL-only), be
accessed by BSD-3 code?
If I didn't know any better, I would think you were trying to create a
"GPL Condom" here :)
Anyway, why all of the BSD-3 stuff here? That makes no sense for kernel
code at all, and this is a relicensing of the file, have you gotten
legal approval of everyone that has modified the file while it was under
the GPL-v2 only text to be able to change it to BSD-3 as well?
Careful, this is a _VERY_ tricky thing to do right. I need a
signed-off-by on this type of patch from your legal council to ensure
that they know exactly what you are doing, and have reviewed it
properly, before I can take it.
Hint, stick to the existing license in the files, it makes more sense,
you are not going to be taking this code out of Linux and putting it
anywhere.
thanks,
greg k-h
next prev parent reply other threads:[~2018-01-16 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 13:19 [PATCH 0/8] staging: fsl-mc: Cleanup Bogdan Purcareata
2018-01-16 13:19 ` [PATCH 1/8] staging: fsl-mc: Cleanup dprc and dpmcp header files Bogdan Purcareata
2018-01-16 13:19 ` [PATCH 2/8] staging: fsl-mc: Consolidate bus core " Bogdan Purcareata
2018-01-16 13:19 ` [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers Bogdan Purcareata
2018-01-16 15:13 ` Greg KH [this message]
2018-01-17 15:56 ` Bogdan Purcareata
2018-01-17 16:16 ` Greg KH
2018-01-16 13:19 ` [PATCH 4/8] staging: fsl-mc: Remove dead code Bogdan Purcareata
2018-01-16 13:19 ` [PATCH 5/8] staging: fsl-mc: Remove unnecessary dependency Bogdan Purcareata
2018-01-16 13:19 ` [PATCH 6/8] staging: fsl-mc: Update include header Bogdan Purcareata
2018-01-16 13:19 ` [PATCH 7/8] staging: fsl-mc: README cleanup Bogdan Purcareata
2018-01-16 13:19 ` [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format Bogdan Purcareata
2018-01-16 15:14 ` Greg KH
2018-01-16 15:40 ` Ruxandra Ioana Ciocoi Radulescu
2018-01-16 16:54 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116151312.GA1174@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bogdan.purcareata@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=horia.geanta@nxp.com \
--cc=ioana.ciornei@nxp.com \
--cc=jason@lakedaemon.net \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=nipun.gupta@nxp.com \
--cc=robh@kernel.org \
--cc=roy.pledge@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=stuyoder@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox