From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbeAPPvk (ORCPT + 1 other); Tue, 16 Jan 2018 10:51:40 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:46660 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751785AbeAPPvi (ORCPT ); Tue, 16 Jan 2018 10:51:38 -0500 X-Google-Smtp-Source: ACJfBosRXBaGte6cd7ki43OjaPJ1OY/33A6MMk7YK03F39T+NnEq3JUK6Lrlr988wxMcpBFbx4rijg== Date: Tue, 16 Jan 2018 16:51:33 +0100 From: Ingo Molnar To: Andy Shevchenko Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 5/6] x86/boot: Allow longer parameter list for earlyprintk Message-ID: <20180116155133.d7dknmm6vodpsqfb@gmail.com> References: <20180114143254.15429-1-andriy.shevchenko@linux.intel.com> <20180114143254.15429-5-andriy.shevchenko@linux.intel.com> <20180116031123.35emo6eiqicbx67q@gmail.com> <1516100227.7000.1004.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516100227.7000.1004.camel@linux.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: * Andy Shevchenko wrote: > On Tue, 2018-01-16 at 04:11 +0100, Ingo Molnar wrote: > > * Andy Shevchenko wrote: > > > > > Allow longer parameter list for earlyprintk to support new coming > > > parameters. > > > > > > No functional change intended. > > > BTW., what happens if the parsed string is longer than this buffer? > > It will be cut up to 63 characters IIUC. Ok, that's fine! Could you please add a comment that explains the limit and the (benign) effects if we go past it? Thanks, Ingo