From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Ganapathi Bhat <gbhat@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Amitkumar Karwar <amitkarwar@gmail.com>,
<linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org,
Ellie Reeves <ellierevves@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Zhiyuan Yang <yangzy@marvell.com>, Tim Song <songtao@marvell.com>,
Cathy Luo <cluo@marvell.com>, James Cao <jcao@marvell.com>,
Brian Norris <briannorris@chromium.org>,
"Signed-off-by : Xinming Hu" <huxm@marvell.com>
Subject: Re: [1/2] Revert "mwifiex: cancel pcie/sdio work in remove/shutdown handler"
Date: Tue, 16 Jan 2018 16:01:14 +0000 (UTC) [thread overview]
Message-ID: <20180116160114.43329608BF@smtp.codeaurora.org> (raw)
In-Reply-To: <20180112210837.112628-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> This reverts commit b713bbf1471b56b572ce26bd02b81a85c2b007f4.
>
> The "fix" in question does not actually fix all related problems, and it
> also introduces new deadlock possibilities. Since commit b014e96d1abb
> ("PCI: Protect pci_error_handlers->reset_notify() usage with
> device_lock()"), the race in question is actually resolved (PCIe reset
> cannot happen at the same time as remove()). Instead, this "fix" just
> introduces a deadlock where mwifiex_pcie_card_reset_work() is waiting on
> device_lock, which is held by PCIe device remove(), which is waiting
> on...mwifiex_pcie_card_reset_work().
>
> The proper thing to do is just to fix the deadlock. Patch for this will
> come separately.
>
> Cc: Signed-off-by: Xinming Hu <huxm@marvell.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
2 patches applied to wireless-drivers-next.git, thanks.
7e34c0d2f631 Revert "mwifiex: cancel pcie/sdio work in remove/shutdown handler"
a64e7a79dd60 mwifiex: resolve reset vs. remove()/shutdown() deadlocks
--
https://patchwork.kernel.org/patch/10161659/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-01-16 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 21:08 [PATCH 1/2] Revert "mwifiex: cancel pcie/sdio work in remove/shutdown handler" Brian Norris
2018-01-12 21:08 ` [PATCH 2/2] mwifiex: resolve reset vs. remove()/shutdown() deadlocks Brian Norris
2018-01-16 16:01 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116160114.43329608BF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=ellierevves@gmail.com \
--cc=gbhat@marvell.com \
--cc=hch@lst.de \
--cc=huxm@marvell.com \
--cc=jcao@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=songtao@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox