From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527AbeAPQBQ (ORCPT + 1 other); Tue, 16 Jan 2018 11:01:16 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:41828 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbeAPQBO (ORCPT ); Tue, 16 Jan 2018 11:01:14 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EA406601D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [1/2] Revert "mwifiex: cancel pcie/sdio work in remove/shutdown handler" From: Kalle Valo In-Reply-To: <20180112210837.112628-1-briannorris@chromium.org> References: <20180112210837.112628-1-briannorris@chromium.org> To: Brian Norris Cc: Ganapathi Bhat , Nishant Sarmukadam , Amitkumar Karwar , , linux-wireless@vger.kernel.org, Ellie Reeves , Christoph Hellwig , Dmitry Torokhov , Zhiyuan Yang , Tim Song , Cathy Luo , James Cao , Brian Norris , "Signed-off-by : Xinming Hu" User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180116160114.43329608BF@smtp.codeaurora.org> Date: Tue, 16 Jan 2018 16:01:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Brian Norris wrote: > This reverts commit b713bbf1471b56b572ce26bd02b81a85c2b007f4. > > The "fix" in question does not actually fix all related problems, and it > also introduces new deadlock possibilities. Since commit b014e96d1abb > ("PCI: Protect pci_error_handlers->reset_notify() usage with > device_lock()"), the race in question is actually resolved (PCIe reset > cannot happen at the same time as remove()). Instead, this "fix" just > introduces a deadlock where mwifiex_pcie_card_reset_work() is waiting on > device_lock, which is held by PCIe device remove(), which is waiting > on...mwifiex_pcie_card_reset_work(). > > The proper thing to do is just to fix the deadlock. Patch for this will > come separately. > > Cc: Signed-off-by: Xinming Hu > Signed-off-by: Brian Norris 2 patches applied to wireless-drivers-next.git, thanks. 7e34c0d2f631 Revert "mwifiex: cancel pcie/sdio work in remove/shutdown handler" a64e7a79dd60 mwifiex: resolve reset vs. remove()/shutdown() deadlocks -- https://patchwork.kernel.org/patch/10161659/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches