From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Loys Ollivier <lollivier@baylibre.com>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Jerome Brunet <jbrunet@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v3] firmware: qcom: scm: Fix incorrect of_node_put calls in scm_init
Date: Tue, 16 Jan 2018 08:45:49 -0800 [thread overview]
Message-ID: <20180116164549.GE478@tuxbook> (raw)
In-Reply-To: <1513345214-22835-1-git-send-email-lollivier@baylibre.com>
On Fri 15 Dec 05:40 PST 2017, Loys Ollivier wrote:
> When using other platform architectures, in the init of the qcom_scm
> driver, of_node_put is called on /firmware if no qcom dt is found.
> This results in a kernel error: Bad of_node_put() on /firmware.
>
> These calls to of_node_put from the qcom_scm init are unnecessary as
> of_find_matching_node and of_platform_populate are calling it
> automatically.
>
> Remove the calls to of_node_put() on fw_np.
>
> Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver")
> Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
Hi Loys,
Your patch is correct! We are however removing all this logic from
qcom_scm_init() in v4.16.
See:
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/commit/?h=for-next&id=3aa0582fdb824139630298880fbf78d4ac774d3c
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/commit/?h=for-next&id=3aa0582fdb824139630298880fbf78d4ac774d3c
Regards,
Bjorn
next prev parent reply other threads:[~2018-01-16 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 13:40 [PATCH v3] firmware: qcom: scm: Fix incorrect of_node_put calls in scm_init Loys Ollivier
2018-01-15 13:25 ` Loys Ollivier
2018-01-16 16:45 ` Bjorn Andersson [this message]
2018-01-16 17:41 ` Sudeep Holla
2018-01-17 23:47 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116164549.GE478@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=jbrunet@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=lollivier@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox