From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751477AbeAPRCz (ORCPT + 1 other); Tue, 16 Jan 2018 12:02:55 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:37865 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbeAPRCw (ORCPT ); Tue, 16 Jan 2018 12:02:52 -0500 X-Google-Smtp-Source: ACJfBouwXt4YC9dqt3upz5+zSny7Zhl9bWa+ZYiv73+vXHLazvxleNnLhPD0f1X4o36CXeqNtPindw== Date: Wed, 17 Jan 2018 00:48:12 +0800 From: Wang YanQing To: Jiri Olsa Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf report: Provide libtraceevent with a kernel symbol resolver Message-ID: <20180116164812.GA4118@udknight> Mail-Followup-To: Wang YanQing , Jiri Olsa , acme@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org References: <20180115044732.GB20373@udknight> <20180115100611.GB14646@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180115100611.GB14646@krava> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Jan 15, 2018 at 11:06:11AM +0100, Jiri Olsa wrote: > On Mon, Jan 15, 2018 at 12:47:32PM +0800, Wang YanQing wrote: > > So that beautifiers wanting to resolve kernel function addresses to > > names can do its work, and when we use "perf report" for output of > > "perf kmem record", we will get kernel symbol output. > > > > Signed-off-by: Wang YanQing > > --- > > tools/perf/builtin-report.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > > index dd4df9a..7b65100 100644 > > --- a/tools/perf/builtin-report.c > > +++ b/tools/perf/builtin-report.c > > @@ -1317,6 +1317,15 @@ int cmd_report(int argc, const char **argv) > > report.range_num = 1; > > } > > > > + if (session->tevent.pevent && > > + pevent_set_function_resolver(session->tevent.pevent, > > + machine__resolve_kernel_addr, > > + &session->machines.host) < 0) { > > + pr_err("%s: failed to set libtraceevent function resolver\n", > > + __func__); > > + return -1; > > + } > > why not calling the wrapper trace_event__register_resolver? The reason is the same as builtin-script doesn't use trace_event__register_resolver, because we only use report and script to analyze offline perf.data, and there could be no tracepoints in perf.data. The wrapper trace_event__register_resolver always initialize tevent.pevent, and calling pevent_set_function_resolver which isn't necessary when there is no tracepoints in the perf.data. > > jirka > > > + > > sort__setup_elide(stdout); > > > > ret = __cmd_report(&report); > > -- > > 1.8.5.6.2.g3d8a54e.dirty > >