From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751787AbeAPQyY (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 16 Jan 2018 11:54:24 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:54428 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751076AbeAPQxs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 Jan 2018 11:53:48 -0500
Date: Tue, 16 Jan 2018 17:53:47 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        James Simmons <jsimmons@infradead.org>,
        NeilBrown <neilb@suse.com>, lustre-devel@lists.lustre.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: staging: lustre: lnet: convert selftest to use workqueues
Message-ID: <20180116165347.GC3682@kroah.com>
References: <8724a144-6e84-7237-3a0a-21812901d88a@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8724a144-6e84-7237-3a0a-21812901d88a@canonical.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Tue, Jan 16, 2018 at 03:59:58PM +0000, Colin Ian King wrote:
> Hi,
> 
> CoverityScan detected a couple of issues, one of which was introduced
> with the following commit:
> 
> commit 6106c0f82481e686b337ee0c403821fb5c3c17ef
> Author: NeilBrown <neilb@suse.com>
> Date:   Thu Jan 11 15:06:40 2018 +1100
> 
> CoverityScan CID#1464078 ("Uninitialized scalar variable")
> 
> I'm not sure what the expected error return for these conditions are, so
> I've not fixed these as I didn't want to hazard a guess.
> 
> static int
> lnet_selftest_init(void)
> {
>         int nscheds;
>         int rc;
> 
> // note here rc is not initialized
> 
>         int i;
> 
>         lst_serial_wq = alloc_ordered_workqueue("lst_s", 0);
>         if (!lst_serial_wq) {
>                 CERROR("Failed to create serial WI scheduler for LST\n");
>                 return rc;
> 
> // garbage value in rc is returned
> 
>         }
>         lst_init_step = LST_INIT_WI_SERIAL;
> 
>         nscheds = cfs_cpt_number(lnet_cpt_table());
>         lst_test_wq = kvmalloc_array(nscheds, sizeof(lst_test_wq[0]),
>                                         GFP_KERNEL | __GFP_ZERO);
>         if (!lst_test_wq)
>                 goto error;
> 
> // this also returns garbage in rc

Already fixed in my tree by a patch from Arnd and me :)

thanks,

greg k-h