* Re: staging: lustre: lnet: convert selftest to use workqueues
@ 2018-01-16 15:59 Colin Ian King
2018-01-16 16:53 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2018-01-16 15:59 UTC (permalink / raw)
To: Oleg Drokin, Andreas Dilger, James Simmons, Greg Kroah-Hartman,
NeilBrown, lustre-devel, devel
Cc: linux-kernel
Hi,
CoverityScan detected a couple of issues, one of which was introduced
with the following commit:
commit 6106c0f82481e686b337ee0c403821fb5c3c17ef
Author: NeilBrown <neilb@suse.com>
Date: Thu Jan 11 15:06:40 2018 +1100
CoverityScan CID#1464078 ("Uninitialized scalar variable")
I'm not sure what the expected error return for these conditions are, so
I've not fixed these as I didn't want to hazard a guess.
static int
lnet_selftest_init(void)
{
int nscheds;
int rc;
// note here rc is not initialized
int i;
lst_serial_wq = alloc_ordered_workqueue("lst_s", 0);
if (!lst_serial_wq) {
CERROR("Failed to create serial WI scheduler for LST\n");
return rc;
// garbage value in rc is returned
}
lst_init_step = LST_INIT_WI_SERIAL;
nscheds = cfs_cpt_number(lnet_cpt_table());
lst_test_wq = kvmalloc_array(nscheds, sizeof(lst_test_wq[0]),
GFP_KERNEL | __GFP_ZERO);
if (!lst_test_wq)
goto error;
// this also returns garbage in rc
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: staging: lustre: lnet: convert selftest to use workqueues
2018-01-16 15:59 staging: lustre: lnet: convert selftest to use workqueues Colin Ian King
@ 2018-01-16 16:53 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2018-01-16 16:53 UTC (permalink / raw)
To: Colin Ian King
Cc: Oleg Drokin, Andreas Dilger, James Simmons, NeilBrown,
lustre-devel, devel, linux-kernel
On Tue, Jan 16, 2018 at 03:59:58PM +0000, Colin Ian King wrote:
> Hi,
>
> CoverityScan detected a couple of issues, one of which was introduced
> with the following commit:
>
> commit 6106c0f82481e686b337ee0c403821fb5c3c17ef
> Author: NeilBrown <neilb@suse.com>
> Date: Thu Jan 11 15:06:40 2018 +1100
>
> CoverityScan CID#1464078 ("Uninitialized scalar variable")
>
> I'm not sure what the expected error return for these conditions are, so
> I've not fixed these as I didn't want to hazard a guess.
>
> static int
> lnet_selftest_init(void)
> {
> int nscheds;
> int rc;
>
> // note here rc is not initialized
>
> int i;
>
> lst_serial_wq = alloc_ordered_workqueue("lst_s", 0);
> if (!lst_serial_wq) {
> CERROR("Failed to create serial WI scheduler for LST\n");
> return rc;
>
> // garbage value in rc is returned
>
> }
> lst_init_step = LST_INIT_WI_SERIAL;
>
> nscheds = cfs_cpt_number(lnet_cpt_table());
> lst_test_wq = kvmalloc_array(nscheds, sizeof(lst_test_wq[0]),
> GFP_KERNEL | __GFP_ZERO);
> if (!lst_test_wq)
> goto error;
>
> // this also returns garbage in rc
Already fixed in my tree by a patch from Arnd and me :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-16 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-16 15:59 staging: lustre: lnet: convert selftest to use workqueues Colin Ian King
2018-01-16 16:53 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox