From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751666AbeAPVoR (ORCPT + 1 other); Tue, 16 Jan 2018 16:44:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:53526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbeAPVoF (ORCPT ); Tue, 16 Jan 2018 16:44:05 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 416E32176E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Marek Szyprowski , Arnd Bergmann , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Pankaj Dubey , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFT 3/3] arm64: dts: exynos: Fix missing missing reg warning for syscon restart nodes Date: Tue, 16 Jan 2018 22:31:29 +0100 Message-Id: <20180116213129.16209-3-krzk@kernel.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180116213129.16209-1-krzk@kernel.org> References: <20180116213129.16209-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Fix DTC warnings like: arch/arm64/boot/dts/exynos/exynos7-espresso.dtb: Warning (simple_bus_reg): Node /soc/syscon-reboot missing or empty reg/ranges property by moving the syscon restart node into the PMU (Power Management Unit) node. The PMU node is the actual block responsible for power management, including typical Exynos on/off/restart procedures. Therefore the syscon restart node logically belongs to it. Signed-off-by: Krzysztof Kozlowski --- Not tested. All tests are welcomed. --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 16 ++++++++-------- arch/arm64/boot/dts/exynos/exynos7.dtsi | 14 +++++++------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 62f276970174..34c3648182d9 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -231,13 +231,6 @@ cpu_on = <0xC4000003>; }; - reboot: syscon-reboot { - compatible = "syscon-reboot"; - regmap = <&pmu_system_controller>; - offset = <0x400>; /* SWRESET */ - mask = <0x1>; - }; - soc: soc { compatible = "simple-bus"; #address-cells = <1>; @@ -794,11 +787,18 @@ }; pmu_system_controller: system-controller@105c0000 { - compatible = "samsung,exynos5433-pmu", "syscon"; + compatible = "samsung,exynos5433-pmu", "syscon", "simple-mfd"; reg = <0x105c0000 0x5008>; #clock-cells = <1>; clock-names = "clkout16"; clocks = <&xxti>; + + reboot: syscon-reboot { + compatible = "syscon-reboot"; + regmap = <&pmu_system_controller>; + offset = <0x400>; /* SWRESET */ + mask = <0x1>; + }; }; gic: interrupt-controller@11001000 { diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index ad9dce6894ce..aa99d49af356 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -492,15 +492,15 @@ }; pmu_system_controller: system-controller@105c0000 { - compatible = "samsung,exynos7-pmu", "syscon"; + compatible = "samsung,exynos7-pmu", "syscon", "simple-mfd"; reg = <0x105c0000 0x5000>; - }; - reboot: syscon-reboot { - compatible = "syscon-reboot"; - regmap = <&pmu_system_controller>; - offset = <0x0400>; - mask = <0x1>; + reboot: syscon-reboot { + compatible = "syscon-reboot"; + regmap = <&pmu_system_controller>; + offset = <0x0400>; + mask = <0x1>; + }; }; rtc: rtc@10590000 { -- 2.11.0