From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH RFC tip/core/rcu] Make SRCU be once again optional
Date: Tue, 16 Jan 2018 15:57:03 -0800 [thread overview]
Message-ID: <20180116235703.GD9671@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAK8P3a3yrhcWihPtgFu2q-_oY4a4nc6pkc+DqpA7OxE+gMVPEQ@mail.gmail.com>
On Wed, Jan 17, 2018 at 12:03:18AM +0100, Arnd Bergmann wrote:
> On Tue, Jan 16, 2018 at 11:55 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> >
> > That fixed the first warning for me, doing the same thing for all three
> > fixed the rest
>
> Now with my workaround applied and the original randconfig that triggered
> the failure, I get another problem:
>
> drivers/base/power/wakeup.c:68:1: error: data definition has no type
> or storage class [-Werror]
> DEFINE_STATIC_SRCU(wakeup_srcu);
>
> Evidently there is at least one driver that uses SRCU but doesn't 'select SRCU'
> in Kconfig. There are probably others that just haven't been found.
Does adding "select SRCU" on "config PM_SLEEP" in kernel/power/Kconfig
fix this?
Thanx, Paul
next prev parent reply other threads:[~2018-01-16 23:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 21:15 [PATCH RFC tip/core/rcu] Make SRCU be once again optional Paul E. McKenney
2017-04-28 21:51 ` Nicolas Pitre
2017-04-29 0:10 ` Paul E. McKenney
2017-05-12 18:41 ` Paul E. McKenney
2017-05-12 18:45 ` Paul E. McKenney
2017-05-12 18:59 ` Nicolas Pitre
2017-05-12 19:10 ` Paul E. McKenney
2017-06-03 3:59 ` Paul E. McKenney
2017-06-03 5:18 ` Nicolas Pitre
2017-06-03 20:36 ` Paul E. McKenney
2018-01-16 21:02 ` Arnd Bergmann
2018-01-16 21:10 ` Arnd Bergmann
2018-01-16 22:34 ` Paul E. McKenney
2018-01-16 22:55 ` Arnd Bergmann
2018-01-16 23:03 ` Arnd Bergmann
2018-01-16 23:57 ` Paul E. McKenney [this message]
2018-01-17 10:29 ` Arnd Bergmann
2018-01-17 16:32 ` Josh Triplett
2018-01-17 17:10 ` Arnd Bergmann
2018-01-17 16:47 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116235703.GD9671@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox