From: Namhyung Kim <namhyung@kernel.org>
To: changbin.du@intel.com
Cc: rostedt@goodmis.org, jolsa@redhat.com, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
kernel-team@lge.com
Subject: Re: [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0'
Date: Wed, 17 Jan 2018 11:35:41 +0900 [thread overview]
Message-ID: <20180117023541.GA6698@danjae.aot.lge.com> (raw)
In-Reply-To: <1516093350-12045-1-git-send-email-changbin.du@intel.com>
On Tue, Jan 16, 2018 at 05:02:27PM +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> I found there are some problems in the tracing parser when I investiage the root
> cause of issues mentioned in below patch.
> https://patchwork.kernel.org/patch/10132953/
>
> This serials can fix them.
>
> v3: Polish commit msg from Steven Rostedt.
> v2:
> - Drop 1 old patch and add a new one.
> - Stop parsing when '\0' found.
>
> Changbin Du (3):
> tracing: detect the string termination character when parsing user
> input string
> tracing: clear parser->idx if parser gets nothing
> tracing: make sure the parsed string always terminates with '\0'
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> kernel/trace/ftrace.c | 2 --
> kernel/trace/trace.c | 14 +++++++-------
> kernel/trace/trace_events.c | 2 --
> 3 files changed, 7 insertions(+), 11 deletions(-)
>
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-01-17 2:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 9:02 [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0' changbin.du
2018-01-16 9:02 ` [PATCH v3 1/3] tracing: detect the string termination character when parsing user input string changbin.du
2018-01-16 9:02 ` [PATCH v3 2/3] tracing: clear parser->idx if parser gets nothing changbin.du
2018-01-16 9:02 ` [PATCH v3 3/3] tracing: make sure the parsed string always terminates with '\0' changbin.du
2018-01-16 17:42 ` [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0' Steven Rostedt
2018-01-17 4:54 ` Du, Changbin
2018-01-17 5:45 ` Namhyung Kim
2018-01-17 5:47 ` Du, Changbin
2018-01-17 2:35 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117023541.GA6698@danjae.aot.lge.com \
--to=namhyung@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@intel.com \
--cc=jolsa@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox