From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbeAQKTU (ORCPT + 1 other); Wed, 17 Jan 2018 05:19:20 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37838 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbeAQKTS (ORCPT ); Wed, 17 Jan 2018 05:19:18 -0500 Date: Wed, 17 Jan 2018 10:19:23 +0000 From: Will Deacon To: Mark Rutland Cc: ard.biesheuvel@linaro.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] efi/arm*: Only register page tables when they exist Message-ID: <20180117101922.GB27892@arm.com> References: <20180116140832.26731-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180116140832.26731-1-mark.rutland@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 02:08:32PM +0000, Mark Rutland wrote: > Currently the arm/arm64 runtime code registers the runtime servies > pagetables with ptdump regardless of whether runtime services page > tables have been created. > > As efi_mm.pgd is NULL in these cases, attempting to dump the efi page > tables results in a NULL pointer dereference in the ptdump code: Acked-by: Will Deacon Ard -- please can you pick this one up? Cheers, Will