public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "shufan_lee(?????????)" <shufan_lee@richtek.com>,
	'ShuFanLee' <leechu729@gmail.com>,
	"cy_huang(?????????)" <cy_huang@richtek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver
Date: Wed, 17 Jan 2018 14:31:03 +0100	[thread overview]
Message-ID: <20180117133103.GB3188@kroah.com> (raw)
In-Reply-To: <20180117120028.GB31635@kuha.fi.intel.com>

On Wed, Jan 17, 2018 at 02:00:28PM +0200, Heikki Krogerus wrote:
> Hi Greg,
> 
> On Wed, Jan 17, 2018 at 12:14:02PM +0100, Greg KH wrote:
> > On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote:
> > > Hi,
> > > 
> > > On Wed, Jan 17, 2018 at 09:30:45AM +0000, shufan_lee(?????????) wrote:
> > > > Dear Heikki,
> > > > 
> > > >   Sorry for bothering.
> > > > 
> > > >   Just want to check is there anything we need to modify?
> > > 
> > > I'll check the patch this week, but please note that we are -rc8, so
> > > nothing is going to happen before -rc1 is out.
> > 
> > If you ack it today, I could queue it up for -rc1 as it is a stand-alone
> > driver...
> 
> The driver does not compile as module:
> 
> ERROR: "cpu_idle_poll_ctrl" [drivers/usb/typec/rt1711h/rt1711h.ko] undefined!

Well of course it has to pass review :)

Why wouuld a driver be calling that function?  That's not right at all,
ick...

Shufan, what are you doing there?

thanks,

greg k-h

  reply	other threads:[~2018-01-17 13:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10  6:59 [PATCH] USB TYPEC: RT1711H Type-C Chip Driver ShuFanLee
2018-01-17  9:30 ` shufan_lee(李書帆)
2018-01-17 11:08   ` Heikki Krogerus
2018-01-17 11:14     ` Greg KH
2018-01-17 12:00       ` Heikki Krogerus
2018-01-17 13:31         ` Greg KH [this message]
2018-01-17 13:33 ` Greg KH
2018-01-17 13:33 ` Greg KH
2018-01-17 13:42 ` Greg KH
2018-01-18 13:13   ` shufan_lee(李書帆)
2018-01-19  8:03     ` 'Greg KH'
2018-01-19  3:09 ` Jun Li
2018-01-19  5:48   ` shufan_lee(李書帆)
2018-01-19  8:22     ` Heikki Krogerus
2018-01-19  9:01       ` shufan_lee(李書帆)
2018-01-19  9:24         ` Heikki Krogerus
2018-01-19 16:02           ` Guenter Roeck
2018-01-22  2:01             ` shufan_lee(李書帆)
2018-01-22 18:50               ` Guenter Roeck
2018-01-29  7:19                 ` shufan_lee(李書帆)
2018-01-29 19:57                   ` Guenter Roeck
2018-01-30 13:21                     ` shufan_lee(李書帆)
2018-01-30 23:25                       ` Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2018-01-09  3:13 shufan_lee(李書帆)
2018-01-09  6:18 ` Randy Dunlap
2018-01-09  8:45   ` shufan_lee(李書帆)
2018-01-09 17:26     ` Randy Dunlap
2018-01-10  2:49       ` shufan_lee(李書帆)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180117133103.GB3188@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cy_huang@richtek.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=leechu729@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shufan_lee@richtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox