From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4108405-1516205149-2-11081175993565556899 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='de', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-api-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516205148; b=qe21/fqQoqEJcfBEw99ePzU6fPLQc00ZJN9cVOFn+3dPKYZ kE3ONlYOwGhtSjQdAKyaAcW9SI8YWvwBfAQedDG7SxIelZahhXAk17bgiUj+49Zc OhPAI0ZsbLC94BJ3SedsshPPqv8LeTHEvJsX5LVtdaa/OPFz5eiHOTpFMFQiStzY BJNIw3PgRYzCq9Y5TVAB63cToP/40Oypvy609+OxRN6FV/gCWa9ub0yeAEhA7eCf ggii5Yrqccg/iCI5GWcerZ0UnQptbFZ9WjPQ7ZwItmp5O6cwqhtMbkCbB/jlaQk1 m/DBMsvRXxd3iLXPIAOiTGbmi3Lad7VsOlVpTcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516205148; bh=cdsB3dk6N9NywQzWnINOIMIY6m Zcbw5jvVddMrfK1X0=; b=NUqLDmERkXZRlZ8X6qtEHDnqJTPxERC6zHPwZYzT2R gZ+R7pLqzXtf1W8cuZ7LnVz0+UqQr6M0Bu029uaIAvLcuGb6Dao3OItXwS8H9Wdt szE+CRFFlexkZNsr4TIfAorvzU2jCF/zaWgpVxv+uDAj4juORsRshNSqF4FkQ19w eflRtdKRz1fXBMUiYTF1Vhgbw0lHgtfElVcYAV5ig3rtu2t4NZ5OFJhK7SorSwaO WZLdzIUZ/Xi73A0jY23Rlp0b6BteSAoZPMzY5A+du/99b4ksn5W2jXgiU4RhbtnB vTV7JE4YJZOYPdXMS8BRB/y5/kqBY/sUx2OSFVYZEPcA== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=lst.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=lst.de header.result=pass header_is_org_domain=yes Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=lst.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=lst.de header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbeAQQFq (ORCPT ); Wed, 17 Jan 2018 11:05:46 -0500 Received: from verein.lst.de ([213.95.11.211]:56092 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbeAQQFp (ORCPT ); Wed, 17 Jan 2018 11:05:45 -0500 Date: Wed, 17 Jan 2018 17:05:43 +0100 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [PATCH 03/32] fs: introduce new ->get_poll_head and ->poll_mask methods Message-ID: <20180117160543.GA5945@lst.de> References: <20180110155853.32348-1-hch@lst.de> <20180110155853.32348-4-hch@lst.de> <20180110210416.GH13338@ZenIV.linux.org.uk> <20180111113600.GA4120@lst.de> <20180111174750.GL13338@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180111174750.GL13338@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-api-owner@vger.kernel.org X-Mailing-List: linux-api@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Jan 11, 2018 at 05:47:50PM +0000, Al Viro wrote: > What I mean is that it would be nice to have do_select() and friends aware of that. > You are hiding the whole thing behind vfs_poll(); sure, we can't really exploit > that while we have the mix of converted and unconverted instances, but it would > be a nice payoff. I have tried to move it out, but I don't think it makes sense yet, given that we rely on passing the poll_table_struct everywhere. Btw, another issue: the procs and debugfs forwarders are in fact already broken right now for epoll and in-kernel callers. ->poll returning does not mean it is safe to release the module - it may still have an active wait_queue_entry on the waitqueue. For now I think I'll drop the support for the proc/debugfs forwarders, because they will need a real fix independent of this series.