From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754378AbeAQSMD (ORCPT <rfc822;w@1wt.eu>);
        Wed, 17 Jan 2018 13:12:03 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:52931 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754251AbeAQSMB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 17 Jan 2018 13:12:01 -0500
Date: Wed, 17 Jan 2018 19:11:48 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        netdev@vger.kernel.org, linux-acpi@vger.kernel.org,
        graeme.gregory@linaro.org, davem@davemloft.net, linux@armlinux.org.uk,
        rafael.j.wysocki@intel.com, f.fainelli@gmail.com,
        antoine.tenart@free-electrons.com, thomas.petazzoni@free-electrons.com,
        gregory.clement@free-electrons.com, stefanc@marvell.com,
        nadavh@marvell.com, neta@marvell.com, ard.biesheuvel@linaro.org,
        jaz@semihalf.com, tn@semihalf.com
Subject: Re: [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support
Message-ID: <20180117181148.GA5894@lunn.ch>
References: <1516208146-4144-1-git-send-email-mw@semihalf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1516208146-4144-1-git-send-email-mw@semihalf.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 17, 2018 at 05:55:39PM +0100, Marcin Wojtas wrote:
> Hi,
> 
> This is a third version of the patchset introducing mvpp2 driver ability
> to operate with ACPI. Until follow-up generic MDIO is introduced
> it can using the link interrupt capability (a.k.a. in-band management)
> on all ports, 1000BaseT RGMII included.
> Driver operation was tested on top of the net-next branch
> with both DT and ACPI on MacchiatoBin and Armada 7040 DB boards.
> 
> The main changes were requested during v2 review, which was
> adding generic helper routines for:
> * interating over available fwnodes (new patch 4/7)
> * getting IRQ directly from fwnode (new patch 3/7)

Hi Marcin

Thanks for adding these helpers. It makes the changes for ACPI much
less invasive and more natural.

Does the IRQ helper solve the issue of getting an interrupt from a
child node? I don't see this explicitly mentioned in the commit.  It
seems to be getting it from a device. Is the child a device?

Thanks

      Andrew