From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1516218320; cv=none; d=google.com; s=arc-20160816; b=zt9oN2ZIem7JDBZcRSSU5yOQLnc9RyLq0KNUImYmbAVy1Tq5R2rvRlykEMqjNZWbKc OalexXykL/9Kq85yOBu+/R8YOyfBJNO5AjZDScR7X3VperNDcwPio2ott57s8RipmeHh 2EOAM4s9eqNJot0kKNngEn36RRoljceheq1ot9W/Z9mJK6RSD+u4qKyU5wiTnuAlGdgY Tmpfjq4Z+PpaIzhGjDWxMr8DxI3Tgul1heJ/7t+WDk1wzZMV13qYXPWpBlDDP2Px9oy2 oaJsotF4RavoHp0UNEsk5HSypSnxTbdF+kHk/gV0Sewmssn/EOpmY94Xrys0dZlJcJ4M r7Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=ADOuJpSdKDddC7MM5OghgZYNJto42Ie9muc8C4sadBw=; b=wZcRCkgxDgE76TcrfNwdAEeitNVO/LrYbZXkDirNQv+Qk6MltL5N4Hnh8T7cpQTm/S 7V2J0N2Qw+sr9D+svoA0KLpNKbJfy0v4fuZaHGOiZ3dB+kHJLmyUKsSqm964Z/xyyznN MW5bncgASUmJlHu2psd0BOmfmY+YQQud5h6qxJbKeLCAC+qH5yj9/GyETME8X/gXZgX8 LMQg9/ZFiW7vg8LnQPnkObfsmvci31rZfu/ib3h4FDqZ+1sLvHUlmBzk3n0C+Nyzydzm 8RSJ6kaV/bWd4XN3D6JJ11ty+0+54lG2zymVNPNzZMfwUOLQxubgq5W5ZVWRxHsIi/xW 7V/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=h6liJoZZ; spf=pass (google.com: domain of marcus.folkesson@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=marcus.folkesson@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=h6liJoZZ; spf=pass (google.com: domain of marcus.folkesson@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=marcus.folkesson@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com X-Google-Smtp-Source: ACJfBot/9fMWGye3bS2CTwsWh+jy0VWjUSAGEKRWlJ2qZFu74yXFuOAlWHOn/PVZPTXWy+QsxgfCYg== Date: Wed, 17 Jan 2018 20:45:16 +0100 From: Marcus Folkesson To: Randy Dunlap Cc: Dmitry Torokhov , Jonathan Corbet , Tomohiro Yoshidomi , David Herrmann , Philippe Ombredanne , Kate Stewart , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] input: pxrc: new driver for PhoenixRC Flight Controller Adapter Message-ID: <20180117194516.GC10949@gmail.com> References: <20180117190716.22380-1-marcus.folkesson@gmail.com> <9607d51a-4382-396c-a4bd-46bbb24ba46e@infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mxv5cy4qt+RJ9ypb" Content-Disposition: inline In-Reply-To: <9607d51a-4382-396c-a4bd-46bbb24ba46e@infradead.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589509666987149281?= X-GMAIL-MSGID: =?utf-8?q?1589870142514893384?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: --mxv5cy4qt+RJ9ypb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Randy! On Wed, Jan 17, 2018 at 11:13:43AM -0800, Randy Dunlap wrote: > On 01/17/2018 11:07 AM, Marcus Folkesson wrote: > > This driver let you plug in your RC controller to the adapter and > > use it as input device in various RC simulators. > >=20 > > Signed-off-by: Marcus Folkesson > > --- >=20 > > diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kc= onfig > > index f3c2f6ea8b44..18ab6dafff41 100644 > > --- a/drivers/input/joystick/Kconfig > > +++ b/drivers/input/joystick/Kconfig > > @@ -351,4 +351,13 @@ config JOYSTICK_PSXPAD_SPI_FF > > =20 > > To drive rumble motor a dedicated power supply is required. > > =20 > > +config JOYSTICK_PXRC > > + tristate "PhoenixRC Flight Controller Adapter" > > + depends on USB_ARCH_HAS_HCD > > + select USB >=20 > Drop the (first) depends and change "select USB" to "depends on USB". >=20 > Argh, there are lots of input/ drivers that do that. That's bad/wrong. > A driver should not select (enable) an entire subsystem. If the user had > the subsystem disabled, it should stay that way. >=20 > Dmitry, you can expect some patches... >=20 Hah, of course it should be "depends on" :-) Other drivers fooled me... Should I fix the other drivers too when I'm on it, or do you? > > + help > > + Say Y here if you want to use the PhoenixRC Flight Controller Adapt= er. > > + > > + To compile this driver as a module, choose M here: the > > + module will be called pxrc. > > endif >=20 > --=20 > ~Randy Best regards Marcus Folkesson --mxv5cy4qt+RJ9ypb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAlpfp8YACgkQiIBOb1ld UjLStg//fdSW3QIp4nfEJPMCabzcWNbdaGeFBQKCTEWzNIeoI/HnzVk4FSggk06e 30Kd6OZCYqkRAT3lndTTUPi2dSIZ18JOAMm1urZ8WzTnrd0x3MrPqdbzpfvIqsrf qCbnz+NB44bo50VgG7rOE8gGk9KUMNW59h+CnvlIfE+s0jqtNQ3Lmi8ZHe0eUKQ4 1+OghVRl0kmjPfE5bQzJ5saqNruaMgjKo2tP1p0fLlFgjp+Kvk61CutNX7KS6iHr BqvTbDN3NXpyjXa51Du7r/47D3DG2uN47rkas1p5Tc/fV2rfSByyDEZVQkWQ9Lx6 LgNykA7L47WxpHnjPn9S6EP8RmO141gIGAuTMK/smcfdBg+vTWuXRHaIDpAJBDQl Oqh7FU/0TkZkmGvXVot+d/HjPVmUgVluj1VPIXawV9PbDDlSEoKaE0qfDPJeEbuh PElWg2U2fKjD2jSY3QtZN6rjIOzZ3eDaWJ9WdC8zKPeFG9aOx3FI/YXbeXK6RXJ0 pQmM2dEgvUsj0ri4lIAmnTcbCRIdH9YuCZlJ3FU+CUX8z7t4o2pct/zAGFALfmwJ n1tqJU+o5o8NlPXemUQd94yAih7vJsEizcX8bddShXV1Q7NAHjTbkFy6xjH1EN+u TeOuI4WsWtiyvUGOz6tiYhXQqflDX05AzmWhB9IXkrmIPbT0cRg= =X1na -----END PGP SIGNATURE----- --mxv5cy4qt+RJ9ypb--