From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbeAQVaf (ORCPT ); Wed, 17 Jan 2018 16:30:35 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:43840 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769AbeAQVad (ORCPT ); Wed, 17 Jan 2018 16:30:33 -0500 X-Google-Smtp-Source: ACJfBotyPKc/76waKfL4kcnITHxVlWiByhxEqPhbnuYCx1WgOXq8Juw8wL01PKkte4+HnzcZfrVWaA== From: Marcus Folkesson To: Dmitry Torokhov , Marcus Folkesson , Tomohiro Yoshidomi , David Herrmann Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] input: joystick: make USB drivers depend on USB Date: Wed, 17 Jan 2018 22:30:10 +0100 Message-Id: <20180117213010.810-1-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A driver should not enable an entire subsystem. Signed-off-by: Marcus Folkesson --- drivers/input/joystick/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig index 332c0cc1b2ab..4a199cff8c68 100644 --- a/drivers/input/joystick/Kconfig +++ b/drivers/input/joystick/Kconfig @@ -279,8 +279,7 @@ config JOYSTICK_JOYDUMP config JOYSTICK_XPAD tristate "X-Box gamepad support" - depends on USB_ARCH_HAS_HCD - select USB + depends on USB help Say Y here if you want to use the X-Box pad with your computer. Make sure to say Y to "Joystick support" (CONFIG_INPUT_JOYDEV) -- 2.15.1