The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, edumazet@google.com, andrew@lunn.ch,
	cphealy@gmail.com, David Decotigny <decot@googlers.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	Alexei Starovoitov <ast@fb.com>,
	Roopa Prabhu <roopa@cumulusnetworks.com>,
	Mahesh Bandewar <maheshb@google.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	Jonas Bonn <jonas@southpole.se>,
	stephen hemminger <stephen@networkplumber.org>,
	Hans Liljestrand <ishkamiel@gmail.com>,
	"Reshetova, Elena" <elena.reshetova@intel.com>,
	Kirill Tkhai <ktkhai@virtuozzo.com>,
	Andrey Vagin <avagin@openvz.org>, Florian Westphal <fw@strlen.de>,
	David Ahern <dsahern@gmail.com>, Xin Long <lucien.xin@gmail.com>,
	Matthias Schiffer <mschiffer@universe-factory.net>,
	Jiri Benc <jbenc@redhat.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: core: Expose number of link up/down transitions
Date: Thu, 18 Jan 2018 00:52:07 +0100	[thread overview]
Message-ID: <20180117235207.GC26967@nanopsycho> (raw)
In-Reply-To: <20180117230704.21949-1-f.fainelli@gmail.com>

Thu, Jan 18, 2018 at 12:06:57AM CET, f.fainelli@gmail.com wrote:
>From: David Decotigny <decot@googlers.com>
>
>Expose the number of times the link has been going UP or DOWN, and
>update the "carrier_changes" counter to be the sum of these two events.
>While at it, also update the sysfs-class-net documentation to cover:
>carrier_changes (3.15), count_link_up (4.16) and count_link_down (4.16)
>
>Signed-off-by: David Decotigny <decot@googlers.com>

[...]


>@@ -161,6 +161,8 @@ enum {
> 	IFLA_EVENT,
> 	IFLA_NEW_NETNSID,
> 	IFLA_IF_NETNSID,
>+	IFLA_COUNT_LINK_UP,
>+	IFLA_COUNT_LINK_DOWN,


	IFLA_LINK_UP_COUNT,
	IFLA_LINK_DOWN_COUNT,

would sound a bit nicer to me.

> 	__IFLA_MAX
> };

  parent reply	other threads:[~2018-01-17 23:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 23:06 [PATCH net-next] net: core: Expose number of link up/down transitions Florian Fainelli
2018-01-17 23:17 ` Jakub Kicinski
2018-01-17 23:49 ` Andrei Vagin
2018-01-18  0:06   ` Andrew Lunn
2018-01-18  0:23     ` Andrei Vagin
2018-01-17 23:52 ` Jiri Pirko [this message]
2018-01-18  0:17   ` David Ahern
2018-01-18  0:28 ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180117235207.GC26967@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=andrew@lunn.ch \
    --cc=ast@fb.com \
    --cc=avagin@openvz.org \
    --cc=cphealy@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=decot@googlers.com \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=elena.reshetova@intel.com \
    --cc=f.fainelli@gmail.com \
    --cc=fw@strlen.de \
    --cc=ishkamiel@gmail.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=jbenc@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=jonas@southpole.se \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=maheshb@google.com \
    --cc=mschiffer@universe-factory.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    --cc=vyasevich@gmail.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox