From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753425AbeARCAc (ORCPT ); Wed, 17 Jan 2018 21:00:32 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46002 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752320AbeARCAa (ORCPT ); Wed, 17 Jan 2018 21:00:30 -0500 Date: Wed, 17 Jan 2018 18:00:25 -0800 From: "Paul E. McKenney" To: Matthew Wilcox Cc: Josh Triplett , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcu: Use wrapper for lockdep asserts Reply-To: paulmck@linux.vnet.ibm.com References: <20180117142430.GB10398@bombadil.infradead.org> <20180117232913.GY9671@linux.vnet.ibm.com> <20180118004143.GA376@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118004143.GA376@bombadil.infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18011802-0040-0000-0000-000003E40D51 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008398; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000247; SDB=6.00976582; UDB=6.00495072; IPR=6.00756509; BA=6.00005782; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019102; XFM=3.00000015; UTC=2018-01-18 02:00:27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011802-0041-0000-0000-000007D96E6F Message-Id: <20180118020025.GA9671@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-18_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801180026 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 17, 2018 at 04:41:43PM -0800, Matthew Wilcox wrote: > On Wed, Jan 17, 2018 at 03:29:13PM -0800, Paul E. McKenney wrote: > > On Wed, Jan 17, 2018 at 06:24:30AM -0800, Matthew Wilcox wrote: > > > > > > From: Matthew Wilcox > > > > > > Commits c0b334c5bfa9 and ea9b0c8a26a2 introduced new sparse warnings > > > by accessing rcu_node->lock directly and ignoring the __private > > > marker. Introduce a new wrapper and use it. Also fix a similar problem > > > in srcutree.c introduced by a3883df3935e. > > > > > > Signed-off-by: Matthew Wilcox > > > > Good catch! Applied for review and testing. > > > > For some reason, I was expecting 0day to catch this sort of thing... > > Funny you should say, it was 0day which pointed it out to me! I changed > lockdep to take a const struct lockdep_map *lock instead of a plain > struct lockdep_map *lock and I got a whinge from 0day that I'd changed > some of the warnings, so I looked into it in case it was my fault. Nary a peep at me. Regardless, glad you caught it, and thank you for the fix! Thanx, Paul