From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <keith.busch@intel.com>
X-Google-Smtp-Source: ACJfBouOklKZolV7PjYW4L0AowoWunZ11wo4AD3VB3V9xD3dz0BAkXZEFFCidCU5yozUUh4SHK5m
ARC-Seal: i=1; a=rsa-sha256; t=1516243980; cv=none;
        d=google.com; s=arc-20160816;
        b=g7f1QpruC6rgnOjLl0/cZBrAwB+koEHIDU1NU9FJfPz+Mi2GBMmKViTONVh5sUzVme
         fAVAtEeQfx34UVoVl04tvletTPzUQFqnJDgBW6NvHFmAapddlemZcgjSpI4e6HggVFCM
         RMmb4KW9axWfTh8VwhbwTOoE9ryjGcQ8MXu+q6EuqyFd9A7yLy/W2XmSh3/cYUeb7GW9
         w0TMV6UhLW7dD56zNRHyJRYIWfnZFKmWPQM2bnorVdcPoHwaEQ2NFRckEcgETt4A1kTw
         15ndW87XpMcepSW0u7asnMIJb24zN3jzj3Wsl226aC80Tbsv9x9jRFCmF/WWYSvhh8wW
         m1eg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=/t6lzZRq5tnJaQonW9CZ7cQs62PlAySKBTU5LEs53Ps=;
        b=lk5VSShwegaqsgXEoEJQesu/WW1AMVNOaFdgKpQAQYI0wTZQXmIc0cpR2Jp0R5Dr2T
         7M5hexSsElV+VSooC0k14HLLE5sLuRP/MjoN6xzVMQGMaklBNXHqrtwgxGN2wvervmuQ
         KZED9SpRCwc0i2mh4EOcR+eN1XeUQJ2pWQzl1sLy+RXJ7HHzhA2qMRYLru0wVJGLpMiL
         8X+6Bn3rLfpmqh+CPPOK2lFNqyt/GSilbtPkpkDBvTo+H2cTM7BRgS8+PpJc+NVq1OBO
         1KDdo5+a398QFl61pr8ajLNTlmz3gSlrd1e0u7vjLNI1r5mRDXhgqUtfzbf+RkbtLtUh
         QIPQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of keith.busch@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=keith.busch@intel.com
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of keith.busch@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=keith.busch@intel.com
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,375,1511856000";
   d="scan'208";a="167025106"
Date: Wed, 17 Jan 2018 19:56:15 -0700
From: Keith Busch <keith.busch@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Oza Pawandeep <poza@codeaurora.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dongdong Liu <liudongdong3@huawei.com>, Wei Zhang <wzhang@fb.com>,
	Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger
 event
Message-ID: <20180118025615.GF7562@localhost.localdomain>
References: <1516185438-31556-1-git-send-email-poza@codeaurora.org>
 <1516185438-31556-5-git-send-email-poza@codeaurora.org>
 <b255864b-1272-0626-f448-db2d9c3710c5@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b255864b-1272-0626-f448-db2d9c3710c5@codeaurora.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1589835695085239135?=
X-GMAIL-MSGID: =?utf-8?q?1589897047900407204?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Wed, Jan 17, 2018 at 08:27:39AM -0800, Sinan Kaya wrote:
> On 1/17/2018 5:37 AM, Oza Pawandeep wrote:
> > +static bool dpc_wait_link_active(struct pci_dev *pdev)
> > +{
> 
> I think you can also make this function common instead of making another copy here.
> Of course, this would be another patch.

It is actually very similar to __pcie_wait_link_active in pciehp_hpc.c,
so there's some opprotunity to make even more common code.