From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd
Date: Thu, 18 Jan 2018 16:21:34 +0100 [thread overview]
Message-ID: <20180118152134.GB24168@lst.de> (raw)
In-Reply-To: <20180117105336.8666-2-jthumshirn@suse.de>
On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote:
> +nvme-core-y := trace.o core.o
trace.o should be conditional on CONFIG_TRACEPOINTS.
> +TRACE_EVENT(nvme_setup_cmd,
> + TP_PROTO(struct nvme_command *cmd),
> + TP_ARGS(cmd),
> + TP_STRUCT__entry(
> + __field(__u8, opcode)
> + __field(__u8, flags)
> + __field(__u16, cid)
> + __field(__le32, nsid)
> + __field(__le64, metadata)
> + __field_struct( struct nvme_command, cmnd )
This still copies the whole SQE. I think that is way to much to
copy, especially given that you also copy many of the fields separately
as well.
next prev parent reply other threads:[~2018-01-18 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 10:53 [PATCH v3 0/2] add tracepoints for nvme command submission and completion Johannes Thumshirn
2018-01-17 10:53 ` [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd Johannes Thumshirn
2018-01-18 1:55 ` Martin K. Petersen
2018-01-18 3:18 ` Keith Busch
2018-01-18 15:21 ` Christoph Hellwig [this message]
2018-01-18 15:32 ` Johannes Thumshirn
2018-01-17 10:53 ` [PATCH v3 2/2] nvme: add tracepoint for nvme_complete_rq Johannes Thumshirn
2018-01-18 1:56 ` Martin K. Petersen
2018-01-18 3:18 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118152134.GB24168@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox