From: Stephen Hemminger <stephen@networkplumber.org>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: "David S. Miller" <davem@davemloft.net>,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is_router
Date: Thu, 18 Jan 2018 16:22:50 -0800 [thread overview]
Message-ID: <20180118162250.013954dd@xeon-e3> (raw)
In-Reply-To: <20180118233745.GA23355@embeddedor.com>
On Thu, 18 Jan 2018 17:37:45 -0600
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote:
> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
LGTM
Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is not enabled")
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2018-01-19 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 23:37 [PATCH] bridge: return boolean instead of integer in br_multicast_is_router Gustavo A. R. Silva
2018-01-19 0:22 ` Stephen Hemminger [this message]
2018-01-19 0:55 ` Gustavo A. R. Silva
2018-01-22 21:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118162250.013954dd@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox