From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754900AbeARQlJ (ORCPT ); Thu, 18 Jan 2018 11:41:09 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51828 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752746AbeARQlH (ORCPT ); Thu, 18 Jan 2018 11:41:07 -0500 Date: Thu, 18 Jan 2018 08:41:00 -0800 From: Sukadev Bhattiprolu To: Randy Dunlap Cc: Michael Ellerman , Benjamin Herrenschmidt , mikey@neuling.org, hbabu@us.ibm.com, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API References: <1516157443-17716-1-git-send-email-sukadev@linux.vnet.ibm.com> <1516157443-17716-3-git-send-email-sukadev@linux.vnet.ibm.com> <2eb418ec-afaf-3f03-40a2-ff9220e3d91f@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2eb418ec-afaf-3f03-40a2-ff9220e3d91f@infradead.org> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.7.1 (2016-10-04) X-TM-AS-GCONF: 00 x-cbid: 18011816-0028-0000-0000-000009020162 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008401; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000247; SDB=6.00976876; UDB=6.00495247; IPR=6.00756798; MB=3.00019113; MTD=3.00000008; XFM=3.00000015; UTC=2018-01-18 16:41:04 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18011816-0029-0000-0000-000039319926 Message-Id: <20180118164100.GC5314@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-18_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801180223 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Randy Dunlap [rdunlap@infradead.org] wrote: > > +#define FTW_FLAGS_PIN_WINDOW 0x1 > > + > > +#define FTW_SETUP _IOW('v', 1, struct ftw_setup_attr) > > ioctls should be documented in Documentation/ioctl/ioctl-number.txt. > Please update that file. Ok. Here is the updated patch. Thanks for the review. Sukadev --- >>From 1f347c199a0b1bbc528705c8e9ddd11c825a80fc Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Thu, 2 Feb 2017 06:20:07 -0500 Subject: [PATCH 2/5] powerpc/ftw: Define FTW_SETUP ioctl API Define the FTW_SETUP ioctl interface for fast thread wakeup (FTW). A follow-on patch will implement the FTW driver and ioctl. Thanks to input from Ben Herrenschmidt, Michael Neuling, Michael Ellerman. Signed-off-by: Sukadev Bhattiprolu --- Changelog[v2] - [Michael Neuling] Use a single VAS_FTW_SETUP ioctl and simplify the interface. - [Randy Dunlap] Reserve/document the ioctl number used. --- Documentation/ioctl/ioctl-number.txt | 1 + include/uapi/misc/ftw.h | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 include/uapi/misc/ftw.h diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt index 3e3fdae..b0f323c 100644 --- a/Documentation/ioctl/ioctl-number.txt +++ b/Documentation/ioctl/ioctl-number.txt @@ -277,6 +277,7 @@ Code Seq#(hex) Include File Comments 'v' 00-1F linux/fs.h conflict! 'v' 00-0F linux/sonypi.h conflict! 'v' C0-FF linux/meye.h conflict! +'v' 20-27 include/uapi/misc/ftw.h 'w' all CERN SCI driver 'y' 00-1F packet based user level communications diff --git a/include/uapi/misc/ftw.h b/include/uapi/misc/ftw.h new file mode 100644 index 0000000..99676b2 --- /dev/null +++ b/include/uapi/misc/ftw.h @@ -0,0 +1,35 @@ +/* + * Copyright 2018 IBM Corp. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + */ + +#ifndef _UAPI_MISC_FTW_H +#define _UAPI_MISC_FTW_H + +#include +#include + +#define FTW_FLAGS_PIN_WINDOW 0x1 + +/* + * Note: The range 0x20-27 for letter 'v' are reserved for FTW ioctls in + * Documentation/ioctl/ioctl-number.txt. + */ +#define FTW_SETUP _IOW('v', 0x20, struct ftw_setup_attr) + +struct ftw_setup_attr { + __s16 version; + __s16 vas_id; /* specific instance of vas or -1 for default */ + __u32 reserved; + + __u64 reserved1; + + __u64 flags; + __u64 reserved2; +}; + +#endif /* _UAPI_MISC_FTW_H */ -- 2.7.4