From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2170473-1516297360-2-4375669502558210062 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='de', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-api-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516297359; b=iVc4Q1WqctnC+ZkP/ytT1ydRyP+MaOTlm4E/xFBX/nuAU9n YXbprEdF2Fx82bNP2AJTehj4xM5DHhMzJQ8GbWWAM1hLrjO7I58PUd6Q0ksEB1IO MWa+fTEx2HXS5LgHPVG4anLb/h1oQwxKrkVac7fJOmpweFzPObgS/0uXjd+ZH1YH ENYD84vndO9nqvLfPQ2wDD78PYEygwEBAx2wd+cMy8oAD5fXDJQHTqxK1VVw7sk7 y3DHnG5wFrf0DqXUTPKdk2BqQw5t37G/h4OGbqpDEf/O1mLZPJgwIBwHEcmGDSjT An6yj7vOW1DSXzrIeiwerFCf6Ny3npU9mgDc83A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516297359; bh=R8aH0fjcm10B75V1P0o5Jt1Jaj 1DfVnkXiZy3tTrBh8=; b=uvdqntr8yOcQXAi7E5fdzS8Mn2zKJzJZF0jvsp9SbT UcYDtGjxG+XIEN2UkxA5nwQMIDUW8VLe4dk3+W2k3Bo4GjbOEfCKdFAsi46/4CXY V90LVkq/8ZrD/dmVbavWfSaJUiIo+HzERqzrvh4rq2CBDQbYUhyzPiGzp0E/6UPA GolsyQwA2LnQpIeRl90V7BiQIAm7xPtIg22HAuN31CHRMvtOh7IuXdWl5MCDK77D mwmMjCYKZ3HnQZBuGMbi2Ijxek/WT6XpldK/z3yE1fHhMPZoFZNehWVmzQgI/aOi +D9A8+u+UHyq0z4jUaBiZQpn/X7cDUjwckGHaKfP7b9A== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=lst.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=lst.de header.result=pass header_is_org_domain=yes Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=lst.de; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=lst.de header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755453AbeARRmb (ORCPT ); Thu, 18 Jan 2018 12:42:31 -0500 Received: from verein.lst.de ([213.95.11.211]:35294 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755407AbeARRma (ORCPT ); Thu, 18 Jan 2018 12:42:30 -0500 Date: Thu, 18 Jan 2018 18:42:28 +0100 From: Christoph Hellwig To: Jeff Moyer Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: aio poll, io_pgetevents and a new in-kernel poll API V3 Message-ID: <20180118174228.GA27412@lst.de> References: <20180117192742.710-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-api-owner@vger.kernel.org X-Mailing-List: linux-api@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Jan 18, 2018 at 11:44:03AM -0500, Jeff Moyer wrote: > Jeff Moyer writes: > > > FYI, this kernel has issues. It will boot up, but I don't have > > networking, and even rebooting doesn't succeed. I'm looking into it. > > A bisect lands on: eventfd: switch to ->poll_mask. That's not super > helpful, though. I did run the ltp eventfd2 tests, and they all pass. > > The actual issue I get on boot is that several services don't start: > > [...] > > Christoph, are you able to reproduce this? No, I can't reproduce any of that. But I don't have a Fedora system either, so this might be a new systemd version doing funky things. The major change in this version was to call ->poll_mask before setting up the wait queue as well. This does the right thing for poll and aio poll, but the more I dig into the epoll code the less sure I am it does the right thing for it, or in fact that epoll does the right thing in general.. Do you still see it with the patch below applied? diff --git a/fs/select.c b/fs/select.c index 707abe79536b..1784c1a29253 100644 --- a/fs/select.c +++ b/fs/select.c @@ -53,9 +53,9 @@ __poll_t vfs_poll(struct file *file, struct poll_table_struct *pt) head = vfs_get_poll_head(file, events); if (!head) return DEFAULT_POLLMASK; - mask = file->f_op->poll_mask(file, events); - if (mask) - return mask; +// mask = file->f_op->poll_mask(file, events); +// if (mask) +// return mask; pt->_qproc(file, head, pt); }