From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ak@linux.intel.com>
X-Google-Smtp-Source: ACJfBouzz8Qdp7Evekk5v1Y1urkGxYVkbcQznHHjt/ArT9COVSxEf//oWn7fMk1p3YQ0vx/9UKvK
ARC-Seal: i=1; a=rsa-sha256; t=1516301424; cv=none;
        d=google.com; s=arc-20160816;
        b=xUJWzFo48ei2FgPhJGxGDkGoVMO//YooLITKvxJApXcr0sZXKzhI6d7YPRzj8xbYpS
         DJFX7LZ8XiDXFQpkal430YThrxhNbZK0nUVqZDkQdxtWQj43wI9+wORLJ2XWkRMxLhcR
         v37o4gjvemJQek/WKjae310ps+y2jA99FWpgc2NqrXUBac/kJY3/YTEPSU9aeuZutn+k
         liefuIzaIF2j5UD6jZO7YdNtAs7hG18Jd5c7Eiz9PrI2bw1llg0XewBgi+WCc8sbT+dZ
         xX4OOSTVLQRAmQz3F5+F/6VvmjB6ytpZv5ixHI9QK5IQWOvfqCcyIBj1lOIoaCR3ElY7
         wbgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=user-agent:in-reply-to:content-disposition:mime-version:references
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=lsChI44dFmOE/aG+bWx4rtYpFRdRUewNKKaYcF31/To=;
        b=J30kjE/PkCTDnE5mjZWdQsbOb9V+L2gxdimu34qPVo+TOKZ5cMyDMBmVqxSKe0wDQ4
         eJvnE5ruuCjhu1fgpCTD9fXwZxo5QMsCYPRtnaEqUVCtxslin7gZG6I2L1EiHhA15LMT
         52Xwfzs2psF55OUBRSdg14IEzfMxV9xuXZRbjJBrWilA/b3XrmBIVo1dMfKd/86ZYgyT
         /R8laNZqNnxje3FZSFQ7t61NAIDe7ZfRSoDNJwi187xF8EG7Gt1/EQ0OlBLtz6JOKCmY
         n/KpXdlgnW3GmyvdCZ837nS++iH6pMhXcjehw6hU2b6Q2+lAeIIU5IE91pbwxkDBHkg2
         mVXQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of ak@linux.intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ak@linux.intel.com
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of ak@linux.intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ak@linux.intel.com
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,378,1511856000";
   d="scan'208";a="11659057"
Date: Thu, 18 Jan 2018 10:50:15 -0800
From: Andi Kleen <ak@linux.intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>, Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linux-foundation.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H . Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes
 for retpoline
Message-ID: <20180118185015.GF7844@tassilo.jf.intel.com>
References: <151627684798.24682.2979775081582774869.stgit@devbox>
 <20180118130157.GE7844@tassilo.jf.intel.com>
 <1516280587.4937.128.camel@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1516280587.4937.128.camel@infradead.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1589931539308254743?=
X-GMAIL-MSGID: =?utf-8?q?1589957282763517798?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Thu, Jan 18, 2018 at 02:03:07PM +0100, David Woodhouse wrote:
> On Thu, 2018-01-18 at 05:01 -0800, Andi Kleen wrote:
> > > 
> > > Side effect: [1/3] will move __x86_indirect_thunk_* functions
> > > in kernel text area. Of course those functions were in the
> > > .text area, but placed in right after _etext. This just moves
> > > it right before the _etext.
> > I assume you tested that with page table isolation on?
> > 
> > The thunks need to be accessible from the trampoline.
> 
> I thought we put it inline in the trampoline.

Yes we did, just want to make sure everything still works.

If it's tested that's fine

-Andi