From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBotcK1stmlsU2S4TmNTSE1GdFsQDHFmU/hJ0wDYQCYMJ5AOR2emYBgyM27lyKYs7TZFR1PnD ARC-Seal: i=1; a=rsa-sha256; t=1516314354; cv=none; d=google.com; s=arc-20160816; b=x4jgmgivzAuvTs7LjKNde2TLkz7faoWS0LBrlBpJCRXU8UoJGRCjFQF6zRat9oMsPX ItdJUZCVBVXWpw46azO5yqfWoj+V0gKkriqB042yv77tdI7zfOBHwaqp79lTlNRJyVQY rkFWkMryk8GLqKw86YkyjSMl1ZQLWe2BdKIOkoCrJugQLzLkkCY6U1z6fk/fKYY80H3r OPkGWMjcYGWzHjT532kUrsobnKbTUxJk5NNzfQ5w1dDJvwvPoN3t6a+5uJknTTGRGFKj 18R7r5P7TODKKecqNiBAEvMQapKmV49WDIaYt1DceG0nIGwZynGTejylLU+KaYPyi3Lu PoEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:arc-authentication-results; bh=2P4gj/69nPfjGLsWVrgKQYgnsgxpg9KaxA7TepUKxIQ=; b=FgZu/6LcQlHFYUOmyd5OO2lRvP/pwBlZFltR+W0Z4gfkwi1gOCZvAnDtKmF3wyVeWS OAUnG2booZUMOZwORQEg4GZbGW9uGxICwl1Y4Qu5QqmeKk1sLV8pmStkjQKJZ5Hsd/6I s87qANXon4DsYQLpZT0r5qr57sI1651ZylKDXtgGU2frBb99IA0cTS00ohy1rB8Y2T5c wlNGSwK2J21FrINg7xs4M7F+/NuKXsMDstU0AMJSeBlt3tGUEWd18iYL+zP4R9VmzUYb z29z5cp2srKbutJ9/2Bpcy6aj3Kv3F5VfmB3p4prHp0gK1OX4V4auI5BttsfI2b7EO++ wj+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of garsilva@embeddedor.com designates 192.185.49.179 as permitted sender) smtp.mailfrom=garsilva@embeddedor.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of garsilva@embeddedor.com designates 192.185.49.179 as permitted sender) smtp.mailfrom=garsilva@embeddedor.com Date: Thu, 18 Jan 2018 16:25:51 -0600 From: "Gustavo A. R. Silva" To: Felipe Balbi , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] usb: gadget: compress return logic into one line Message-ID: <20180118222551.GA18589@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - linuxfoundation.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.155.104.111 X-Source-L: No X-Exim-ID: 1ecId7-000Zzz-Sf X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.155.104.111]:45678 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 2 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589970840277024792?= X-GMAIL-MSGID: =?utf-8?q?1589970840277024792?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Simplify return logic and avoid unnecessary variable assignment. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/legacy/ncm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/legacy/ncm.c b/drivers/usb/gadget/legacy/ncm.c index fcee1ee0..8465f08 100644 --- a/drivers/usb/gadget/legacy/ncm.c +++ b/drivers/usb/gadget/legacy/ncm.c @@ -102,10 +102,8 @@ static int ncm_do_config(struct usb_configuration *c) } f_ncm = usb_get_function(f_ncm_inst); - if (IS_ERR(f_ncm)) { - status = PTR_ERR(f_ncm); - return status; - } + if (IS_ERR(f_ncm)) + return PTR_ERR(f_ncm); status = usb_add_function(c, f_ncm); if (status < 0) { -- 2.7.4