From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932553AbeASThD (ORCPT ); Fri, 19 Jan 2018 14:37:03 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46038 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932314AbeASTgy (ORCPT ); Fri, 19 Jan 2018 14:36:54 -0500 Date: Fri, 19 Jan 2018 14:36:51 -0500 (EST) Message-Id: <20180119.143651.630642000688996110.davem@davemloft.net> To: colin.king@canonical.com Cc: jiri@mellanox.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][devlink-next] devlink: make functions a couple of new functions static From: David Miller In-Reply-To: <20180117112303.20149-1-colin.king@canonical.com> References: <20180117112303.20149-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 17 Jan 2018 11:23:03 +0000 > From: Colin Ian King > > The functions devlink_resource_find and devlink_resource_validate_children > are local to the source and do not need to be in global scope, so make > them static. > > Cleans up sparse warnings: > symbol 'devlink_resource_find' was not declared. Should it be static? > warning: symbol 'devlink_resource_validate_children' was not declared. > Should it be static? > > Signed-off-by: Colin Ian King Applied.