From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBovk4oPOZS25e/zx8F6XnY3WtelQIcAAfdUOXxcWZg7OQaB9p5u7urfmceh2vYQCMHb31335 ARC-Seal: i=1; a=rsa-sha256; t=1516325996; cv=none; d=google.com; s=arc-20160816; b=vPl91c5vWYeIUUlVZ5ODvBPPyL6kOO+CH0BmRGOY06ZDrxYfn7hkfl+g8hehOcbxFj VeLjpfE8JiKTnQaWm7vCsrd/N1EFZR/Bdzj1a97jNFYt1Lo5EXTWIyGrZipHjNdsJjnS tUsa1A83q25mZZs0I08FTq8H2Hupqy5XRWgGxnva+teeFgUQTx8h9Eqn0EbFJ9PG7QkU A5jdf1L5+FCBUhEq3Jehdn4TzNT6xAkg9wgkDOogyn707y9ckOfq7M78rjMoQ6I8615j 0V2laFNQMZhP//SIzUh5EH4wx+drmrp+7PetJG6CQLZRQzZ8nE/CVL8h/nVkboodT92v QF7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:arc-authentication-results; bh=FRW7FZJXNvFB+DYZFC3JQkRexgyNh/1hA7DFgC4L/M4=; b=RP72VALwEcFCLChwQ6gEVKC1ZlG2+kwHNPZ5r/Os7sWanzyeZflOAQxP7THHP6yPsx qhJecFQfW3bbLRDX4T8Ib90hAn+ZTp7UmbbUfKYq3g6OK8/15oC50rtJc9sJE5S1yejV V1m0ZjvpCfn41oFvIQF2DyliU6WFgzQQssCPgpxZYX30aV8gbAlvJ4jZvC0QvY+qsepR eYaJXRP00uo0DlniJJXz75VYOM971m08yzbU6PnsEtdKogooL6sQIIz2YNVBRYdeCpNc 7ZGtn1V3DgVFFM/LqMwZTPuf8QV0KPggoUL20fPWOoLAsUPALktCI8ompMKHPrUCCo3T M3JA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of keith.busch@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=keith.busch@intel.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of keith.busch@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=keith.busch@intel.com X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,379,1511856000"; d="scan'208";a="11740605" Date: Thu, 18 Jan 2018 18:43:10 -0700 From: Keith Busch To: Sinan Kaya Cc: poza@codeaurora.org, Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Wei Zhang , Timur Tabi Subject: Re: [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger event Message-ID: <20180119014310.GA12043@localhost.localdomain> References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-5-git-send-email-poza@codeaurora.org> <20180118025615.GF7562@localhost.localdomain> <153733e36c151d2a549b814e4232c0df@codeaurora.org> <1629ca15-81f6-f5f4-8f9c-d0a575272dd6@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1629ca15-81f6-f5f4-8f9c-d0a575272dd6@codeaurora.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835695085239135?= X-GMAIL-MSGID: =?utf-8?q?1589983048259998755?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Thu, Jan 18, 2018 at 11:35:59AM -0500, Sinan Kaya wrote: > On 1/18/2018 12:32 AM, poza@codeaurora.org wrote: > > On 2018-01-18 08:26, Keith Busch wrote: > >> On Wed, Jan 17, 2018 at 08:27:39AM -0800, Sinan Kaya wrote: > >>> On 1/17/2018 5:37 AM, Oza Pawandeep wrote: > >>> > +static bool dpc_wait_link_active(struct pci_dev *pdev) > >>> > +{ > >>> > >>> I think you can also make this function common instead of making another copy here. > >>> Of course, this would be another patch. > >> > >> It is actually very similar to __pcie_wait_link_active in pciehp_hpc.c, > >> so there's some opprotunity to make even more common code. > > > > in that case there has to be a generic function in > > drives/pci.c > > > > which addresses folowing functions from > > > > pcie-dpc.c: > > dpc_wait_link_inactive > > dpc_wait_link_active > > > > drivers/pci/hotplug/pciehp_hpc.c > > pcie_wait_link_active > > > > > > all aboe making one generic function to be moved to drives/pci.c > > > > please let me know if this is okay. > > Works for me. Keith/Bjorn? Yep, I believe common solutions that reduce code is always encouraged in the Linux kernel.