Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

Greg KH
2018-01-17T13:31:13Z

On Wed, Jan 17, 2018 at 02:00:28PM +0200, Heikki Krogerus wrote:
> Hi Greg,
>
> On Wed, Jan 17, 2018 at 12:14:02PM +0100, Greg KH wrote:
> > On Wed, Jan 17, 2018 at 01:08:58PM +0200, Heikki Krogerus wrote:
> > > Hi,
> > >
> > > On Wed, Jan 17, 2018 at 09:30:45AM +0000, shufan_lee(?????????) wrote:
> > > > Dear Heikki,
> > > >
> > > > Sorry for bothering.
> > > >
> > > > Just want to check is there anything we need to modify?
> > >
> > > I'll check the patch this week, but please note that we are -rc8, so
> > > nothing is going to happen before -rc1 is out.
> >
> > If you ack it today, I could queue it up for -rc1 as it is a stand-alone
> > driver...
>
> The driver does not compile as module:
>
> ERROR: "cpu_idle_poll_ctrl" [drivers/usb/typec/rt1711h/rt1711h.ko] undefined!

Well of course it has to pass review :)

Why wouuld a driver be calling that function? That's not right at all,
ick...

Shufan, what are you doing there?

thanks,

greg k-h