From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755389AbeASKPh (ORCPT ); Fri, 19 Jan 2018 05:15:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37052 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbeASKP2 (ORCPT ); Fri, 19 Jan 2018 05:15:28 -0500 Date: Fri, 19 Jan 2018 11:15:24 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Peter Zijlstra , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Andi Kleen , Alexander Shishkin Subject: Re: [PATCH] perf build: Display EXTRA features for VF=1 build Message-ID: <20180119101524.GA20115@krava> References: <20180107160356.28203-1-jolsa@kernel.org> <20180107160356.28203-2-jolsa@kernel.org> <20180108151709.GI25476@kernel.org> <20180108152037.GJ25476@kernel.org> <20180108152433.GK25476@kernel.org> <20180108171122.GC18380@krava> <20180108171649.GD18380@krava> <20180109092646.GB11520@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180109092646.GB11520@krava> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 09, 2018 at 10:26:46AM +0100, Jiri Olsa wrote: > On Mon, Jan 08, 2018 at 06:16:49PM +0100, Jiri Olsa wrote: > > On Mon, Jan 08, 2018 at 06:11:22PM +0100, Jiri Olsa wrote: > > > On Mon, Jan 08, 2018 at 12:24:33PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > > SNIP > > > > > > > > > > > Works: > > > > > > > > [acme@jouet perf]$ ldd ~/bin/perf | grep babel > > > > libbabeltrace-ctf.so.1 => /lib64/libbabeltrace-ctf.so.1 (0x00007fcb688d0000) > > > > libbabeltrace.so.1 => /lib64/libbabeltrace.so.1 (0x00007fcb67e92000) > > > > [acme@jouet perf]$ rpm -q libbabeltrace-devel > > > > libbabeltrace-devel-1.5.3-1.fc27.x86_64 > > > > [acme@jouet perf]$ > > > > > > > > But then, if we show: > > > > > > > > Auto-detecting system features: > > > > ... dwarf: [ on ] > > > > ... dwarf_getlocations: [ on ] > > > > ... glibc: [ on ] > > > > ... gtk2: [ on ] > > > > ... libaudit: [ on ] > > > > ... libbfd: [ on ] > > > > ... libelf: [ on ] > > > > ... libnuma: [ on ] > > > > ... numa_num_possible_cpus: [ on ] > > > > ... libperl: [ on ] > > > > ... libpython: [ on ] > > > > ... libslang: [ on ] > > > > ... libcrypto: [ on ] > > > > ... libunwind: [ on ] > > > > ... libdw-dwarf-unwind: [ on ] > > > > ... zlib: [ on ] > > > > ... lzma: [ on ] > > > > ... get_cpuid: [ on ] > > > > ... bpf: [ on ] > > > > > > > > Shoudln't we tell the user that babeltrace was linked too? > > > > > > the logic is just to simply display the state of features > > > which we provide in FEATURE_DISPLAY variable, which is > > > believed to be common and important enough to display > > > status about > > > > > > maybe we could display it with 'make VF=1' output? > > > > like in patch attached ;-) > > with changelog > > thanks, > jirka Arnaldo, could you please check this one? thanks, jirka > > > --- > Display state of the rest of the features (FEATURE_TESTS_EXTRA) > for 'make VF=1' build. These features are detected manually by > perf's Makefile.config so they can't be displayed with the > main list, but only after we're done in Makefile.config. > > $ make VF=1 > BUILD: Doing 'make -j4' parallel build > > Auto-detecting system features: > ... dwarf: [ on ] > ... dwarf_getlocations: [ on ] > ... glibc: [ on ] > ... gtk2: [ on ] > > SNIP > > ... timerfd: [ on ] > ... sched_getcpu: [ on ] > ... sdt: [ on ] > ... setns: [ on ] > > extra features: > ... bionic: [ OFF ] > ... compile-32: [ on ] > ... compile-x32: [ OFF ] > ... cplus-demangle: [ on ] > ... hello: [ OFF ] > ... libbabeltrace: [ on ] > ... liberty: [ on ] > ... liberty-z: [ on ] > ... libunwind-debug-frame: [ OFF ] > ... libunwind-debug-frame-arm: [ OFF ] > ... libunwind-debug-frame-aarch64: [ OFF ] > > SNIP > > Link: http://lkml.kernel.org/n/tip-q4r73p2c6wfag2s38fpsim8v@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/Makefile.config | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > index 12dec6ea5ed2..92265b32dddd 100644 > --- a/tools/perf/Makefile.config > +++ b/tools/perf/Makefile.config > @@ -947,6 +947,10 @@ define print_var_code > endef > > ifeq ($(VF),1) > + # Display EXTRA features which are detected manualy > + # from here with feature_check call and thus cannot > + # be partof global state output. > + $(foreach feat,$(FEATURE_TESTS_EXTRA),$(call feature_print_status,$(feat),)) > $(call print_var,prefix) > $(call print_var,bindir) > $(call print_var,libdir) > -- > 2.13.6 >