From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755881AbeASPnN (ORCPT ); Fri, 19 Jan 2018 10:43:13 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:45980 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932423AbeASPnE (ORCPT ); Fri, 19 Jan 2018 10:43:04 -0500 X-Google-Smtp-Source: AH8x227NZq/5h7fVPiB9bxQu6/ERnVLJw5CeVZi3nvJZCWvLTB63CRJvfKmBFOf9YcsQKQbJGr7gsA== Date: Fri, 19 Jan 2018 10:43:01 -0500 From: Jon Mason To: Arnd Bergmann Cc: Dave Jiang , Allen Hubbe , Gary R Hook , Serge Semin , linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] NTB: ntb_perf: fix printing of resource_size_t Message-ID: <20180119154300.GA23366@kudzu.us> References: <20180119145813.1141817-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180119145813.1141817-1-arnd@arndb.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 19, 2018 at 03:55:28PM +0100, Arnd Bergmann wrote: > On 32-bit architectures, resource_size_t is usually 'unsigned int' or > 'unsigned long' but not 'unsigned long long', so we get a warning > about printing the wrong data: > > drivers/ntb/test/ntb_perf.c: In function 'perf_setup_peer_mw': > drivers/ntb/test/ntb_perf.c:1390:35: error: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t {aka unsigned int}' [-Werror=format=] > > This changes the format string to the special %pa that is already > used elsewhere in the same file. Applied to my ntb-next branch. Thanks, Jon > > Fixes: b83003b3fdc1 ("NTB: ntb_perf: Add full multi-port NTB API support") > Signed-off-by: Arnd Bergmann > --- > drivers/ntb/test/ntb_perf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c > index 8de72f3fba4d..1829a17dd461 100644 > --- a/drivers/ntb/test/ntb_perf.c > +++ b/drivers/ntb/test/ntb_perf.c > @@ -1387,8 +1387,8 @@ static int perf_setup_peer_mw(struct perf_peer *peer) > if (max_mw_size && peer->outbuf_size > max_mw_size) { > peer->outbuf_size = max_mw_size; > dev_warn(&peer->perf->ntb->dev, > - "Peer %d outbuf reduced to %#llx\n", peer->pidx, > - peer->outbuf_size); > + "Peer %d outbuf reduced to %pa\n", peer->pidx, > + &peer->outbuf_size); > } > > return 0; > -- > 2.9.0 >