From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBov1sI/JhzIx2PE06mljybsQNUFm4mb9AE7r2M7UYGW2DlVplxJ7t8j5sGSe2vpUdJV9YEa7 ARC-Seal: i=1; a=rsa-sha256; t=1516385109; cv=none; d=google.com; s=arc-20160816; b=sI2a0jq8lx73cnOHtd9Y/GmPN36Oa6U+xAgDkalJ3mvm3fBxAw9qBD+G6a/LaVaPDq xR9o2xS+kgYM+cA1uX7++noB46PxqUFpYvHuhsBAkJ11rjCrgsmfS2ytoqWi8SGwUaOl F8RqToC5obPkgU5LRquibD1OxztvfdTPcwrRcQoibz/hhMHNKtfKeKNn3bASW48ohKHA msoszIpNrNmGew2lc8VCnGfDm6FA7OdXm9HPLi9IOLsQJxPpbIAHxFnWr96d0g8cnHoc 58oli6tNVGgNCNKoavDPW5HCCFq+PvZcr8ZOAJ/LgwEqtjosV1btQ4syfmzIsM4iKzN+ jCCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:sender:date :arc-authentication-results; bh=MrNJuextgzQy1SRslMSKeOd9baDnLB+ERvpUtktv/uk=; b=IoqIAVCHILuWjicRniKWaTcpGI9fYvUv9bwJtoEBHk72zwXpTAsacqR3DxTvotl6I0 N7jWt8HJDx8UOoyHQ1oEmOrnktk1oaf8JwIULT0m7gHwNdF4rSZhZFW2KloSX97uxb8F EyRLnb88z1D+8LmyKyK0RsObnGZGzzlW2Lnec2YtxbScnjObRcXxvhf2DfQa+/KmNvLV M37EAhIkccVxGiYR8fsUO2OkYpPEcAwqixi1FyWhgL1WUUc/0bE3eLGQRCuyUH+ajOTL japvlJoHeo4wr8YKhtisS+UWLunK/iwoVJxNS/zUMm8uDE+BdlO5br19rRY3jfY5XT2o d1Pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of ladis@linux-mips.org designates 148.251.95.138 as permitted sender) smtp.mailfrom=ladis@linux-mips.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of ladis@linux-mips.org designates 148.251.95.138 as permitted sender) smtp.mailfrom=ladis@linux-mips.org Date: Fri, 19 Jan 2018 19:05:04 +0100 Sender: Ladislav Michl From: Ladislav Michl To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang , Bjorn Helgaas , Greg Kroah-Hartman , Thomas Gleixner Subject: [PATCH 2/2] PCI: Fix double mem region release in devm_pci_remap_cfg_resource() Message-ID: <20180119180504.GC31540@lenoch> References: <20180119180310.GA31540@lenoch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180119180310.GA31540@lenoch> User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590045032758147459?= X-GMAIL-MSGID: =?utf-8?q?1590045032758147459?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: devm_release_mem_region() is called explicitely in case devm_pci_remap_cfgspace() fails, however the same release function is later called also as devres release of devm_request_mem_region() causing double resource free. Fixes: 490cb6ddb17d ("PCI: Implement devm_pci_remap_cfgspace()") Signed-off-by: Ladislav Michl --- drivers/pci/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 764ca7b8840d..8f9d81a23ca5 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3607,7 +3607,6 @@ void __iomem *devm_pci_remap_cfg_resource(struct device *dev, dest_ptr = devm_pci_remap_cfgspace(dev, res->start, size); if (!dest_ptr) { dev_err(dev, "ioremap failed for resource %pR\n", res); - devm_release_mem_region(dev, res->start, size); dest_ptr = IOMEM_ERR_PTR(-ENOMEM); } -- 2.15.1