From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224evI5PEnQhdhXjipMbopcJ3bXjJLY2kexGSu8JTczFabx5P7FZ6FVZXHib4Jhxyyheg5Fk ARC-Seal: i=1; a=rsa-sha256; t=1516404968; cv=none; d=google.com; s=arc-20160816; b=NWYxvkAYzGe+xjzw8Fs2/2v3NfqLlXkF20PRQitAL5mRgRLQt90DjknGZDZufhdWTb M77GEP0/nYwGtUrYcvG85D1rhVGTIZPP1x/PnyYJyx3PzSgcSxZQgWntGKMusTsszhmH fgdlH/CusxjS1wnv6LC/D7Rv1xzm7hA8yx93RQ2Gtx7Pe9WrQdBIEHNhC051xIbZWWMP e8tJRszhVhi4C4mXL1OLCR3ms922J/U9WJT3pxCcRvWbPouQGSmAmnhptNidMBNcg+sm +t7fVVvEhJwacLAQ4gbz5O4hjPrhF6TkCp4gwnmkB+Pj9UxmAXvY/SI9VzNblSB3dZsz lq8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:sender:date :arc-authentication-results; bh=goTi0lJoC+rNfnFq5+JcZNmc+6PCzIwNv5cJ2ciFF04=; b=UxdpEmiBdyKmw6kgQW03BYZd2AvZNFFQEcxTRgCAI82vghoBseUn0xqghCT23ilIgp yMlscDWgRmgAP+6LThaQUq5BaL6vG/JAq+VkvJdSMZ2S25c1KVYPUTF0POLTfq65USAF boA6MU1EFU0WFx/wejYhjdexCT7/oh6AuI9H2r1xUoCQyvhVtsauKPIAJ4M5eivUQ46y oXzpCWPpZviNtyqnFVA1UxT3m81BRFzqBoJMTZ9Iul7W/ADCm+JwQIXYVVufwPNtL08m zqwNFogUgzCZBMPAtIur6+QeIyDrgTYrgc8Oixd3tIc9ZFp+9VIUjHdQIFmXE2BLm1Pt 3LNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of ladis@linux-mips.org designates 148.251.95.138 as permitted sender) smtp.mailfrom=ladis@linux-mips.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of ladis@linux-mips.org designates 148.251.95.138 as permitted sender) smtp.mailfrom=ladis@linux-mips.org Date: Sat, 20 Jan 2018 00:36:06 +0100 Sender: Ladislav Michl From: Ladislav Michl To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bjorn Helgaas , Greg Kroah-Hartman , Thomas Gleixner Subject: Re: [PATCH 0/2] Fix double mem region release Message-ID: <20180119233606.GA18837@lenoch> References: <20180119180310.GA31540@lenoch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180119180310.GA31540@lenoch> User-Agent: Mutt/1.9.2 (2017-12-15) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590044941259509211?= X-GMAIL-MSGID: =?utf-8?q?1590065857183877366?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Jan 19, 2018 at 07:03:10PM +0100, Ladislav Michl wrote: > Two one-liners for the same issue, second bug occurrence is just > a copy&pasted mistake from 2011... > > Ladislav Michl (2): > devres: Fix double mem region release in devm_ioremap_resource() > PCI: Fix double mem region release in devm_pci_remap_cfg_resource() Hmm, that is really shame :-/ My test setup triggered "Trying to free nonexistent resource" warning, but dissasembly of lib/devres.o shows no call to devres_destroy, which seems that WARN_ON in __devm_release_region() is optimized out. Strange. So far sorry for the noise, I'll try figure out what broke after weekend. > drivers/pci/pci.c | 1 - > lib/devres.c | 1 - > 2 files changed, 2 deletions(-) > > -- > 2.15.1 >