From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754641AbeATEOD (ORCPT ); Fri, 19 Jan 2018 23:14:03 -0500 Received: from gateway34.websitewelcome.com ([192.185.149.13]:34240 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754041AbeATENz (ORCPT ); Fri, 19 Jan 2018 23:13:55 -0500 Date: Fri, 19 Jan 2018 21:52:09 -0600 From: "Gustavo A. R. Silva" To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] power: supply: da9030_battery: fix boolean value assignment in da9030_set_charge Message-ID: <20180120035209.GA15623@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.234.72 X-Source-L: No X-Exim-ID: 1eckCQ-000KGb-Kn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.234.72]:49004 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 9 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Fixes: 342d765e011f ("power_supply: Add Dialog DA9030 battery charger driver") Signed-off-by: Gustavo A. R. Silva --- drivers/power/supply/da9030_battery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/da9030_battery.c b/drivers/power/supply/da9030_battery.c index 5ca0f4d..2cc05bc 100644 --- a/drivers/power/supply/da9030_battery.c +++ b/drivers/power/supply/da9030_battery.c @@ -238,10 +238,10 @@ static void da9030_set_charge(struct da9030_charger *charger, int on) val = DA9030_CHRG_CHARGER_ENABLE; val |= (charger->charge_milliamp / 100) << 3; val |= (charger->charge_millivolt - 4000) / 50; - charger->is_on = 1; + charger->is_on = true; } else { val = 0; - charger->is_on = 0; + charger->is_on = false; } da903x_write(charger->master, DA9030_CHARGE_CONTROL, val); -- 2.7.4