From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751216AbeATGFj (ORCPT <rfc822;w@1wt.eu>);
        Sat, 20 Jan 2018 01:05:39 -0500
Received: from mail-pg0-f44.google.com ([74.125.83.44]:36994 "EHLO
        mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750993AbeATGFf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 20 Jan 2018 01:05:35 -0500
X-Google-Smtp-Source: AH8x227bAZKPn0oWRROzQN0Nnl0sO9RenSbTpAShpRtdA/ne2GRb4suothAdBd5z5DVkz5uJtu7bcQ==
Date: Sat, 20 Jan 2018 15:05:29 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Petr Mladek <pmladek@suse.com>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] printk: drop redundant devkmsg_log_str memsets
Message-ID: <20180120060529.GA8371@jagdpanzerIV>
References: <20180119043901.1728-1-sergey.senozhatsky@gmail.com>
 <20180119091707.0a15a24d@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180119091707.0a15a24d@gandalf.local.home>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (01/19/18 09:17), Steven Rostedt wrote:
> Yep, and even the sysctl checks for the terminating nul string, so
> there's no leaks of any kind.
> 
> Tested by adding: printk.devkmsg=on and running:
> 
>  $ hexdump -C /proc/sys/kernel/printk_devkmsg
> 00000000  6f 6e 0a                                          |on.|
> 00000003
> 
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

thanks.

	-ss