From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754826AbeATNwY (ORCPT <rfc822;w@1wt.eu>);
        Sat, 20 Jan 2018 08:52:24 -0500
Received: from mail.free-electrons.com ([62.4.15.54]:56944 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751130AbeATNwT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 20 Jan 2018 08:52:19 -0500
Date: Sat, 20 Jan 2018 14:52:17 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Colin King <colin.king@canonical.com>
Cc: Miquel Raynal <miquel.raynal@free-electrons.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
        linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] mtd: nand: marvell: remove redundant variable
 'oob_len'
Message-ID: <20180120145217.368504bb@bbrezillon>
In-Reply-To: <20180119075954.15009-1-colin.king@canonical.com>
References: <20180119075954.15009-1-colin.king@canonical.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 19 Jan 2018 07:59:54 +0000
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable oob_len is assigned and never read, hence it is redundant and
> can be removed.
> 
> Cleans up clang warnings:
> 
> drivers/mtd/nand/marvell_nand.c:1356:6: warning: Value stored to 'oob_len'
> during its initialization is never read
> drivers/mtd/nand/marvell_nand.c:1369:4: warning: Value stored to 'oob_len'
> is never read
> 

Applied.

Thanks,

Boris

> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/mtd/nand/marvell_nand.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/marvell_nand.c b/drivers/mtd/nand/marvell_nand.c
> index 4bd53b360277..f15ab37edf4e 100644
> --- a/drivers/mtd/nand/marvell_nand.c
> +++ b/drivers/mtd/nand/marvell_nand.c
> @@ -1353,7 +1353,6 @@ static int marvell_nfc_hw_ecc_bch_write_page_raw(struct mtd_info *mtd,
>  	int data_len = lt->data_bytes;
>  	int spare_len = lt->spare_bytes;
>  	int ecc_len = lt->ecc_bytes;
> -	int oob_len = spare_len + ecc_len;
>  	int spare_offset = 0;
>  	int ecc_offset = (lt->full_chunk_cnt * lt->spare_bytes) +
>  		lt->last_spare_bytes;
> @@ -1366,7 +1365,6 @@ static int marvell_nfc_hw_ecc_bch_write_page_raw(struct mtd_info *mtd,
>  			data_len = lt->last_data_bytes;
>  			spare_len = lt->last_spare_bytes;
>  			ecc_len = lt->last_ecc_bytes;
> -			oob_len = spare_len + ecc_len;
>  		}
>  
>  		/* Point to the column of the next chunk */