From: "Jörg Rödel" <joro@8bytes.org>
To: Joe Perches <joe@perches.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars()
Date: Sun, 21 Jan 2018 08:19:04 +0100 [thread overview]
Message-ID: <20180121071903.GD28161@8bytes.org> (raw)
In-Reply-To: <1516498672.24895.2.camel@perches.com>
On Sat, Jan 20, 2018 at 05:37:52PM -0800, Joe Perches wrote:
> While Markus' commit messages are nearly universally terrible,
> is there really any signficant value in knowing when any
> particular OOM condition occurs other than the subsystem that
> became OOM?
>
> You're going to be hosed in any case.
>
> Why isn't the generic OOM stack dump good enough?
Because if we know the exact allocation attempt that failed right away,
we can more easily check if we can rewrite it so that it is more likely
to succeed, e.g. rewriting one higher-order allocation to multiple
order-0 allocations.
Joerg
next prev parent reply other threads:[~2018-01-21 7:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 13:00 [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars() SF Markus Elfring
2018-01-20 13:34 ` Jörg Rödel
2018-01-20 14:55 ` SF Markus Elfring
2018-01-20 19:40 ` Jörg Rödel
2018-01-21 1:37 ` Joe Perches
2018-01-21 7:19 ` Jörg Rödel [this message]
2018-01-21 19:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180121071903.GD28161@8bytes.org \
--to=joro@8bytes.org \
--cc=dwmw2@infradead.org \
--cc=elfring@users.sourceforge.net \
--cc=iommu@lists.linux-foundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).