From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751063AbeAUHYG (ORCPT ); Sun, 21 Jan 2018 02:24:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:48602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbeAUHYE (ORCPT ); Sun, 21 Jan 2018 02:24:04 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62ABE2176E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mcgrof@kernel.org From: "Luis R. Rodriguez" To: fstests@vger.kernel.org Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, "Luis R. Rodriguez" Subject: [PATCH 1/2] fstests: move expunge test into a helper Date: Sat, 20 Jan 2018 23:24:00 -0800 Message-Id: <20180121072401.1047-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.13.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move the expunge test into a helper. Signed-off-by: Luis R. Rodriguez --- check | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/check b/check index f8db3cd6dfab..0ba71d5d2005 100755 --- a/check +++ b/check @@ -485,6 +485,18 @@ _check_filesystems() fi } +_expunge_test() +{ + TEST_ID="$1" + if [ -s $tmp.xlist ]; then + if grep $TEST_ID $tmp.xlist > /dev/null 2>&1 ; then + echo " [expunged]" + return 1 + fi + fi + return 0 +} + _prepare_test_list if $OPTIONS_HAVE_SECTIONS; then @@ -672,11 +684,9 @@ for section in $HOST_OPTIONS_SECTIONS; do rm -f $seqres.out.bad # check if we really should run it - if [ -s $tmp.xlist ]; then - if grep $seqnum $tmp.xlist > /dev/null 2>&1 ; then - echo " [expunged]" - continue - fi + _expunge_test $seqnum + if [ $? -eq 1 ]; then + continue fi # slashes now in names, sed barfs on them so use grep -- 2.15.0