From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2272ngQMfdLSz22epQ47hwLO4nIYUXdNbqZtG3U82JW6zAeAjB7QSSkX3onmByHtWLJyXtX8 ARC-Seal: i=1; a=rsa-sha256; t=1516610488; cv=none; d=google.com; s=arc-20160816; b=TPzfnIkMFd1NokUbnGAqOClIWtvoDGbQP4Bjn8A1yITDqu/pnhHdsYZL1Akd9nRBZi /dGLkq6tKWwZdxgNRnC74W2FQwZ00I5gSfrkrqGftGYNBK0WRBZCgkKJTw4chTcw19By 9m7BJrTf26xpq89W1KYu+BI6TjB1zgYluKmjuYf75A1fFwxKN672afRUAxiUKZ7FJ6fz 7s+L+i3Z20MVKvfK2f0GeJ+GOH4Qv237HWk31CvIfIFCYmxSpKrRixKZOigzI3zBhcLJ w4IIu1YLUGY+vxbPp6GJLxOnXnRntFrdBOLXHLqa0yPCnh0NnZ3t9pxkJ4FTTCx3vzof fFew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=epaQOSsLdVp/Z9ig3BWnSeJgMgpMvA0l0rUkgw6gcfU=; b=UvqvQBRR+ia1F3o36yy9vo5t2/k/3ssGHsGMHk+LRGb+DwSLyXRot11pA8H6QFkth1 aEcwz2uBZ/Li2X9/ZlqCcwoEe6ssyOFCp/vC8mvEo8arlv7kHVrlSSXo/Dc6zxwiRPfA a37rO3ZlniDyP/nrkeD8xQCOx5RI5M0nwzXbztzpHf9gFPTVmlJUbiL6Az3Pyf/ikBT9 UDP3mvNza9DGS+LJqVTZC0rDWVBXnLsk89bKXLPykQPshVp9HZkZPK7R4qoxODJKzP3p nuBi8+xz6a8FT6nXKCLQbJrzmJCUMjuVaaxxZD05G0hrbWBfrU7uWMdSh2BkdSHvjVjV bGOw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Torvalds , Thomas Gleixner , David Woodhouse , "Peter Zijlstra (Intel)" , gnomes@lxorguk.ukuu.org.uk, Rik van Riel , Andi Kleen , Josh Poimboeuf , thomas.lendacky@amd.com, Jiri Kosina , Andy Lutomirski , Dave Hansen , Kees Cook , Tim Chen , Greg Kroah-Hartman Subject: [PATCH 4.4 20/53] x86/retpoline: Remove compile time warning Date: Mon, 22 Jan 2018 09:40:12 +0100 Message-Id: <20180122083911.136146456@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083910.299610926@linuxfoundation.org> References: <20180122083910.299610926@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590281359884856529?= X-GMAIL-MSGID: =?utf-8?q?1590281359884856529?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Gleixner commit b8b9ce4b5aec8de9e23cabb0a26b78641f9ab1d6 upstream. Remove the compile time warning when CONFIG_RETPOLINE=y and the compiler does not have retpoline support. Linus rationale for this is: It's wrong because it will just make people turn off RETPOLINE, and the asm updates - and return stack clearing - that are independent of the compiler are likely the most important parts because they are likely the ones easiest to target. And it's annoying because most people won't be able to do anything about it. The number of people building their own compiler? Very small. So if their distro hasn't got a compiler yet (and pretty much nobody does), the warning is just annoying crap. It is already properly reported as part of the sysfs interface. The compile-time warning only encourages bad things. Fixes: 76b043848fd2 ("x86/retpoline: Add initial retpoline support") Requested-by: Linus Torvalds Signed-off-by: Thomas Gleixner Cc: David Woodhouse Cc: Peter Zijlstra (Intel) Cc: gnomes@lxorguk.ukuu.org.uk Cc: Rik van Riel Cc: Andi Kleen Cc: Josh Poimboeuf Cc: thomas.lendacky@amd.com Cc: Linus Torvalds Cc: Jiri Kosina Cc: Andy Lutomirski Cc: Dave Hansen Cc: Kees Cook Cc: Tim Chen Cc: Greg Kroah-Hartman Link: https://lkml.kernel.org/r/CA+55aFzWgquv4i6Mab6bASqYXg3ErV3XDFEYf=GEcCDQg5uAtw@mail.gmail.com Signed-off-by: Greg Kroah-Hartman --- arch/x86/Makefile | 2 -- 1 file changed, 2 deletions(-) --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -194,8 +194,6 @@ ifdef CONFIG_RETPOLINE RETPOLINE_CFLAGS += $(call cc-option,-mindirect-branch=thunk-extern -mindirect-branch-register) ifneq ($(RETPOLINE_CFLAGS),) KBUILD_CFLAGS += $(RETPOLINE_CFLAGS) -DRETPOLINE - else - $(warning CONFIG_RETPOLINE=y, but not supported by the compiler. Toolchain update recommended.) endif endif