From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1406405-1516610681-2-6214466921301013103 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516610680; b=XuKV6/IpLfLVuyt0YQvmRGA1kILNbqDPEVq/IB+81IuJnq0 WIs3MHC2TTpon28q2mqVRbVJednBMkzf2mzG+mvTNuLApMG7Udagegkzss2RVOjc D1Fn3MiB/rXEBOCGJq+cucr/7lsHTZQUo4c/1gRAiJns9ynma9FQHRuqyw6/E0bc qd88AT3dR6aILRmxLSJz97vf/HJKj6WkA6BWPT3oFrHMRm3XNr9ZyVOHjyZhVm1H +GdlbGvHLAzbHp4PeEqdEikh/inEoYbY3o6D0QVlDPlfkHXbkTFzl2rnlu7Jtgl0 01o5+4AQCGH8syIT+o1S5c7ngFlgxctUMqBpDqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=arctest; t=1516610680; bh=soj99iZ4uuTwEx9FQ22CaEjsdt CIDFcgKR6NRL/1jJ8=; b=EBLh2JIbz8qWgr7N2Xn2PieosedE4hZbnSYxjsJEFk rdzMWthxP/W9bmssmDC/4OMpkiBHQzpU7qk6dBe7Xz98UjYSP/3JIj60eT9iKOjZ 1JEnKzpIaYW3kYDU8E5V9LtZM4iZVHwm2teFB8a6XDe/2x1q2l6n1cheMywFGFLS Nl0kw6QL2vtO9NhD87PDB+ipe4/1P1edZj66JqeSL/tbGbsrgTTjxng2YgwdtMvR YjarZyFkF0zB+8e2K2uB8/goJuBXaBxse6FoGUt+xTalmxJsfqOOoyGfIHvxTEL+ 2qfUwKQkdAnwUl+r+pedHc+9x9PrfDYc/HD+GkpKZAWA== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbeAVIo2 (ORCPT ); Mon, 22 Jan 2018 03:44:28 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59192 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbeAVInI (ORCPT ); Mon, 22 Jan 2018 03:43:08 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "H. Nikolaus Schaller" , Dmitry Torokhov Subject: [PATCH 4.4 35/53] Input: twl6040-vibra - fix DT node memory management Date: Mon, 22 Jan 2018 09:40:27 +0100 Message-Id: <20180122083911.861697119@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083910.299610926@linuxfoundation.org> References: <20180122083910.299610926@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: H. Nikolaus Schaller commit c52c545ead97fcc2f4f8ea38f1ae3c23211e09a8 upstream. commit e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support") made the separate vibra DT node to a subnode of the twl6040. It now calls of_find_node_by_name() to locate the "vibra" subnode. This function has a side effect to call of_node_put on() for the twl6040 parent node passed in as a parameter. This causes trouble later on. Solution: we must call of_node_get() before of_find_node_by_name() Signed-off-by: H. Nikolaus Schaller Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/twl6040-vibra.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/input/misc/twl6040-vibra.c +++ b/drivers/input/misc/twl6040-vibra.c @@ -262,6 +262,7 @@ static int twl6040_vibra_probe(struct pl int vddvibr_uV = 0; int error; + of_node_get(twl6040_core_dev->of_node); twl6040_core_node = of_find_node_by_name(twl6040_core_dev->of_node, "vibra"); if (!twl6040_core_node) {