From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x224IvDEi4yuAIniG77E5QsvG3D8CH1lq7zVJA4Lg+ueEcqXM/AM7AxdBloKXxZdc7wSxOTzp ARC-Seal: i=1; a=rsa-sha256; t=1516611297; cv=none; d=google.com; s=arc-20160816; b=BSRhle4V1eTEOPavfP7SjX+TxEMzp8XHMAwhuLkRq7uyU2f1679946drjx0woF78kA 4/z1eyjyb3pZs8ejWdU2LXksPbRI2kF84bJUzHHrM5WcjgHX3XkHztGtvYJJDQTkBKyK nd5XmBKozKKKYebyZ/wAHfOzJjksQM/jzWl/aESDahY7tlKchFWnEl/CMNlUBBTEhMfP 3ZnRJ5PL0m+eQdoxACksHOj78clIhFQaHpxs/dRliqy7aY3x6tRYOe8mC+T5MtmByahh fofIuzpkG4vCqAy7JzS3Idw63aJd8nJ2AvdJDmWlcrOCyZV9EaOY+wxeYlmpSgeTa0nY 6KEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=6W0auDwXWVh2VrhQAoFpOPSTInogcAOEm+v2jYg41g8=; b=ehmDYWxC11Naganzbn1i3yQCAPZ7KCa/lbzJvLZnsg/w1xpanfj2XqjDRbCDgxqUFp 3iBDqtqKGIqqD1mpZfMUCidWbgDF/Qmc5f03JL4INhdu6wronSWvYqh31BDcWTUeEqMs rBPG33UFk8O1b4IQsobYe79lFWLRYYRCKqRAYVMQ25o5WF3fHAEF1XQNHl2sHJObcAR0 p3Ea/HK1HmhnAXhz/wBUt8biG6ddFPd5zNxWkZhF3QyZg5Bm4EfMGYEhMPwifTkQWFzW T3seFJs7z5+CVN/poQ8tyDCYyeNsMssa6rxfW4VJLdRy2Dpz8kNcQR2Vl0wJ8Nd8PdXV yjoA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Dmitry Torokhov Subject: [PATCH 4.9 27/47] Input: twl4030-vibra - fix sibling-node lookup Date: Mon, 22 Jan 2018 09:45:38 +0100 Message-Id: <20180122083927.614317529@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083925.568134913@linuxfoundation.org> References: <20180122083925.568134913@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590281470922682604?= X-GMAIL-MSGID: =?utf-8?q?1590282207266767709?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 5b189201993ab03001a398de731045bfea90c689 upstream. A helper purported to look up a child node based on its name was using the wrong of-helper and ended up prematurely freeing the parent of-node while searching the whole device tree depth-first starting at the parent node. Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel") Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning") Signed-off-by: Johan Hovold Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/twl4030-vibra.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/input/misc/twl4030-vibra.c +++ b/drivers/input/misc/twl4030-vibra.c @@ -178,12 +178,14 @@ static SIMPLE_DEV_PM_OPS(twl4030_vibra_p twl4030_vibra_suspend, twl4030_vibra_resume); static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata, - struct device_node *node) + struct device_node *parent) { + struct device_node *node; + if (pdata && pdata->coexist) return true; - node = of_find_node_by_name(node, "codec"); + node = of_get_child_by_name(parent, "codec"); if (node) { of_node_put(node); return true;