From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226p9fhjnhp/HMe4NTqIOGpHH06OYxFWVeKncIs7VsDyHzVwwUeydx9iTja78irJGpl0Nkhb ARC-Seal: i=1; a=rsa-sha256; t=1516611061; cv=none; d=google.com; s=arc-20160816; b=WqHaw6FuWbri6eTL7ONNbmSXAbd/8LkWSdoAA5ew8IQLmJMAOMZx+MaYvpJ0a75Upg r1olIFyQma8KufF4OWaMEGfhVp6ZK5ROlR4KG5ppOWs8YkL/5q2/90JYQaq7V/kuAUnk ozNlInu8j1QCPZ0wrpG0GtTxhtTPftQZEh+vyp5l651fjY28pDR0whZGZxA/W4pD9qSl 9dgSmvVPA6yJWsy11JLjL1b4EuyuzVxAFFkuWTtHI6Sx5TsQM5FSFKXLWWqaOYUoWCrj uImUM/O5XiOIdJr/1Q/5+UklgCvkUmWRn/+ZWZKjpNY/4sG42s5Gs2ylJF54SfwzCKjy rIXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=2OZWpBJeGIOk2EvWjPpHuHMNfkZcmSIqehvcevlsV8U=; b=TzC0WYy3U/nRhmQYb9UBCwf61BOngYPv7xB/J1UfBxBhoFnJqLVHUdZrE91Ogzqgiu NZOtz1vVzmdpxvLaLr8cQntlSpu/BzkGuemIIeyS6g9q1kNGQ/O2YZLtaAWT+vOGjT6Z g5rjSc2rGX0wzpxHs5x9Es5sNjCecngT12p0tS1sgZFM5Q2paK8Kpd1BDb2cOzs+UFlx tuYyaiqOMWxPkOk9sCbi/pAPC8haIjyppMWUla6JT9gCKZzbq/1N/fqIMB74lrmR2lIW iOexd+fKj9C31snBCnBYrABjXnkmX98fWdRGfce2TizK1plAzblVmhRiVuNjhg9OgFZE YjWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Simon Ser , Josh Poimboeuf , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Guenter Roeck Subject: [PATCH 4.14 05/89] objtool: Fix seg fault caused by missing parameter Date: Mon, 22 Jan 2018 09:44:45 +0100 Message-Id: <20180122083955.230840728@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083954.683903493@linuxfoundation.org> References: <20180122083954.683903493@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590281960229279660?= X-GMAIL-MSGID: =?utf-8?q?1590281960229279660?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Simon Ser commit d89e426499cf36b96161bd32970d6783f1fbcb0e upstream. Fix a seg fault when no parameter is provided to 'objtool orc'. Signed-off-by: Simon Ser Signed-off-by: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/9172803ec7ebb72535bcd0b7f966ae96d515968e.1514666459.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar Cc: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- tools/objtool/builtin-orc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/tools/objtool/builtin-orc.c +++ b/tools/objtool/builtin-orc.c @@ -44,6 +44,9 @@ int cmd_orc(int argc, const char **argv) const char *objname; argc--; argv++; + if (argc <= 0) + usage_with_options(orc_usage, check_options); + if (!strncmp(argv[0], "gen", 3)) { argc = parse_options(argc, argv, check_options, orc_usage, 0); if (argc != 1) @@ -52,7 +55,6 @@ int cmd_orc(int argc, const char **argv) objname = argv[0]; return check(objname, no_fp, no_unreachable, true); - } if (!strcmp(argv[0], "dump")) {