From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227ZSYJi28A+SQyiEEm1qyo6lPZvLXtZKBzy6ONLTCZr66TWM+BMJGa4N5Jpjd/IGrmSWYNw ARC-Seal: i=1; a=rsa-sha256; t=1516611233; cv=none; d=google.com; s=arc-20160816; b=Kwxj1fOQgQvFsRNxbR3wRzWdXyEZtY41GWUQC7fG0ry3bdeFK5QrOMZM9D0HG38mdA 1M7jQSKdqxbT6RjA3hUlGT3xJlroL8kuBI2gpmvP0Vv7fbWnugHc8XCTHhG0AgXqFQF3 9yg6UZNTmiEIhf7eoCRaK2rckkYZ0IpO4Jy5XmU2ABZrAjgRo5R5FCVo1IIm6dxdCMFK XHSE3HjmfHnwEdCgpAaqUMnJdX5rij48e3lpaB3Z9dYc1AIOEo4bW1Lku4CCiycBHIDt oqSyv4rWdTjnw7n+TvSxhT3n74yn/ahr6bp2J/MscmbQk3BZJOGH2KYemz562cdISFGW xhsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=zdCX2xgIJX1mcdGncx2HkKJXSMZ5BgFftEJBLF0kTHI=; b=ixolkBrEAtXCCotQEQ8ObjpC+1E/H3JRD7VKAF5Sy7nMmYnOQq9IKl/rkIx8TYu1VY lvu2DiV8rxfP+v4zwh8V7s1l9oXzcfqNNEYkySkD81zyDKsuze78Z/SfswdziwaFStRK cQfyLQZXb8HE4jtK6mNJ2z320v1Ys2EZPlwTcY18TzztUNOBpxto6fTwrz89kqKAOP4U nWYF6/ElyoOkHHUNuDaKbHz4SGDMYsl0AbdOwD83drLcus24psSiH/aaxaqo6qqNuplT 1fkXwOPjRJfq0NIboRN1jwgTVIZeMkMiFf2h+ZpBR7o8aVfnJ+rrg+tqu8l7FT1545Sm 1zzg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Dmitry Torokhov Subject: [PATCH 4.14 54/89] Input: twl4030-vibra - fix sibling-node lookup Date: Mon, 22 Jan 2018 09:45:34 +0100 Message-Id: <20180122084000.098699369@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083954.683903493@linuxfoundation.org> References: <20180122083954.683903493@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590281470922682604?= X-GMAIL-MSGID: =?utf-8?q?1590282140761877961?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 5b189201993ab03001a398de731045bfea90c689 upstream. A helper purported to look up a child node based on its name was using the wrong of-helper and ended up prematurely freeing the parent of-node while searching the whole device tree depth-first starting at the parent node. Fixes: 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel") Fixes: e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning") Signed-off-by: Johan Hovold Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/twl4030-vibra.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/input/misc/twl4030-vibra.c +++ b/drivers/input/misc/twl4030-vibra.c @@ -178,12 +178,14 @@ static SIMPLE_DEV_PM_OPS(twl4030_vibra_p twl4030_vibra_suspend, twl4030_vibra_resume); static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata, - struct device_node *node) + struct device_node *parent) { + struct device_node *node; + if (pdata && pdata->coexist) return true; - node = of_find_node_by_name(node, "codec"); + node = of_get_child_by_name(parent, "codec"); if (node) { of_node_put(node); return true;