From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227nW266opC2ZrI0R1SBxtCBkYiVQX0hL3Db+OeEmBCE7/PlZy8pVEjlbFor3+j1MZIt4reX ARC-Seal: i=1; a=rsa-sha256; t=1516611224; cv=none; d=google.com; s=arc-20160816; b=CnkgIcxmhNrkyI6ohbwiMeKIRi37DQ1mrJyOrl/sv332fkg7MbMRgqB4RcYyGvNNw0 7HuSI+sU2FtD0QEmvyznnRJ3FUsZ3joGn5stIupEgnbkENdYUGcaXE9zeOLp56rldLkk POFOtZfh7StB5Y+0ZDghZub6B3ib5DiM39flrFyUQ+6TCJ1JrxA4l7oyoFmfPg5c12iA 1+uwqW51DNiW621JoX6DjK0+zsJnV/YX+uBek8d0jElWndqYGBDhzJrawe974baaU4TS 6YN8E8agqG5ueKDo1pYdi0XmAPZ5MCgasUpP1gSQBqc0z+Mh1nSEaEvZIn/83+/qBp8S d/fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=puo3yYaahJZp3sm51th2wzC6NbYooKaQcX84m7/Klew=; b=FEFNUnsdnrByySXpLWPTFusHmZEE5K9PzFfra/khgtQWHEgv057h+UvGIv37NiDDND mF9X6eP88NLLUBkLEG3qZfuinUmt8en87KwtNHYomoXbpPCoKtHg/qqlcuIJSkESiqM0 xl2HNoPy3aN4gcMdK0U1jQoBgP0odnJdxVRao8968B60svS1nuLQCZAicqDrSoTH292O A2YPVVWL2l7L4UuGz8dJBSyHQPE3ZC2gBWTegCDsW1J5Ls3NUiNdxFME+FDBpb+L++zD Y42geUTS1SrVAHzup5cIhu573Z5PpJ6GjRex95h37nOGlHt1gMRiBsbPCbRFNMBPO7Bm Y5bA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, James Hogan , Paul Burton , linux-mips@linux-mips.org, Ralf Baechle Subject: [PATCH 4.14 78/89] MIPS: CM: Drop WARN_ON(vp != 0) Date: Mon, 22 Jan 2018 09:45:58 +0100 Message-Id: <20180122084002.242771771@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083954.683903493@linuxfoundation.org> References: <20180122083954.683903493@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590282131920067298?= X-GMAIL-MSGID: =?utf-8?q?1590282131920067298?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: James Hogan commit c04de7b1ad645b61c141df8ca903ba0cc03a57f7 upstream. Since commit 68923cdc2eb3 ("MIPS: CM: Add cluster & block args to mips_cm_lock_other()"), mips_smp_send_ipi_mask() has used mips_cm_lock_other_cpu() with each CPU number, rather than mips_cm_lock_other() with the first VPE in each core. Prior to r6, multicore multithreaded systems such as dual-core dual-thread interAptivs with CPU Idle enabled (e.g. MIPS Creator Ci40) results in mips_cm_lock_other() repeatedly hitting WARN_ON(vp != 0). There doesn't appear to be anything fundamentally wrong about passing a non-zero VP/VPE number, even if it is a core's region that is locked into the other region before r6, so remove that particular WARN_ON(). Fixes: 68923cdc2eb3 ("MIPS: CM: Add cluster & block args to mips_cm_lock_other()") Signed-off-by: James Hogan Reviewed-by: Paul Burton Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/17883/ Signed-off-by: Ralf Baechle Signed-off-by: Greg Kroah-Hartman --- arch/mips/kernel/mips-cm.c | 1 - 1 file changed, 1 deletion(-) --- a/arch/mips/kernel/mips-cm.c +++ b/arch/mips/kernel/mips-cm.c @@ -292,7 +292,6 @@ void mips_cm_lock_other(unsigned int clu *this_cpu_ptr(&cm_core_lock_flags)); } else { WARN_ON(cluster != 0); - WARN_ON(vp != 0); WARN_ON(block != CM_GCR_Cx_OTHER_BLOCK_LOCAL); /*